From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752365AbbEDUAw (ORCPT ); Mon, 4 May 2015 16:00:52 -0400 Received: from mga02.intel.com ([134.134.136.20]:12523 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115AbbEDUAv (ORCPT ); Mon, 4 May 2015 16:00:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,367,1427785200"; d="scan'208";a="705111130" Message-ID: <1430769649.19214.1.camel@theros.lm.intel.com> Subject: Re: [PATCH] block: pmem: Add dependency on HAS_IOMEM From: Ross Zwisler To: Richard Weinberger Cc: axboe@kernel.dk, dan.j.williams@intel.com, mingo@kernel.org, willy@linux.intel.com, linux-kernel@vger.kernel.org Date: Mon, 04 May 2015 14:00:49 -0600 In-Reply-To: <1430765937-32694-1-git-send-email-richard@nod.at> References: <1430765937-32694-1-git-send-email-richard@nod.at> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20.rez) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-05-04 at 20:58 +0200, Richard Weinberger wrote: > Not all architectures have io memory. > > Fixes: > drivers/block/pmem.c: In function ‘pmem_alloc’: > drivers/block/pmem.c:146:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration] > pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size); > ^ > drivers/block/pmem.c:146:18: warning: assignment makes pointer from integer without a cast [enabled by default] > pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size); > ^ > drivers/block/pmem.c:182:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] > iounmap(pmem->virt_addr); > ^ > > Signed-off-by: Richard Weinberger > --- > drivers/block/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig > index eb1fed5..3ccef9e 100644 > --- a/drivers/block/Kconfig > +++ b/drivers/block/Kconfig > @@ -406,6 +406,7 @@ config BLK_DEV_RAM_DAX > > config BLK_DEV_PMEM > tristate "Persistent memory block device support" > + depends on HAS_IOMEM > help > Saying Y here will allow you to use a contiguous range of reserved > memory as one or more persistent block devices. Reviewed-by: Ross Zwisler