mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hanjun Guo <hanjun.guo@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Will Deacon <will.deacon@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
	Sudeep Holla <Sudeep.Holla@arm.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linaro-acpi@lists.linaro.org, Hanjun Guo <hanjun.guo@linaro.org>
Subject: [PATCH v2 6/7] ACPI / processor: return specific error instead of -1
Date: Tue,  5 May 2015 10:46:37 +0800	[thread overview]
Message-ID: <1430793998-21631-7-git-send-email-hanjun.guo@linaro.org> (raw)
In-Reply-To: <1430793998-21631-1-git-send-email-hanjun.guo@linaro.org>

Since invalid_logical_cpuid() can check error values, so
return specific error instead of -1 for acpi_map_cpuid().

Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
---
 drivers/acpi/processor_core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index b1ec78b..fd4140d 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -215,12 +215,12 @@ int acpi_map_cpuid(phys_cpuid_t phys_id, u32 acpi_id)
 		 * Ignores phys_id and always returns 0 for the processor
 		 * handle with acpi id 0 if nr_cpu_ids is 1.
 		 * This should be the case if SMP tables are not found.
-		 * Return -1 for other CPU's handle.
+		 * Return -EINVAL for other CPU's handle.
 		 */
 		if (nr_cpu_ids <= 1 && acpi_id == 0)
 			return acpi_id;
 		else
-			return -1;
+			return -EINVAL;
 	}
 
 #ifdef CONFIG_SMP
@@ -233,7 +233,7 @@ int acpi_map_cpuid(phys_cpuid_t phys_id, u32 acpi_id)
 	if (phys_id == 0)
 		return phys_id;
 #endif
-	return -1;
+	return -ENODEV;
 }
 
 int acpi_get_cpuid(acpi_handle handle, int type, u32 acpi_id)
-- 
1.9.1


  parent reply	other threads:[~2015-05-05  2:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-05  2:46 [PATCH v2 0/7] minor cleanups for ACPI processor driver Hanjun Guo
2015-05-05  2:46 ` [PATCH v2 1/7] ACPI / processor: remove cpu_index in acpi_processor_get_info() Hanjun Guo
2015-05-05 11:08   ` Sudeep Holla
2015-05-05  2:46 ` [PATCH v2 2/7] ACPI / processor: remove phys_id " Hanjun Guo
2015-05-05  2:46 ` [PATCH v2 3/7] ACPI / processor: Introduce invalid_logical_cpuid() Hanjun Guo
2015-05-05 11:15   ` Sudeep Holla
2015-05-05 12:04     ` Rafael J. Wysocki
2015-05-05 13:15       ` Hanjun Guo
2015-05-05 12:01   ` Rafael J. Wysocki
2015-05-05 13:15     ` Hanjun Guo
2015-05-05 15:12   ` Boris Ostrovsky
2015-05-05  2:46 ` [PATCH v2 4/7] Xen / ACPI / processor: use invalid_logical_cpuid() Hanjun Guo
2015-05-05  2:46 ` [PATCH v2 5/7] Xen / ACPI / processor: Remove unneeded NULL check in xen_acpi_processor_enable() Hanjun Guo
2015-05-05 10:29   ` Stefano Stabellini
2015-05-09 22:06     ` Konrad Rzeszutek Wilk
2015-05-05  2:46 ` Hanjun Guo [this message]
2015-05-05  2:46 ` [PATCH v2 7/7] ACPI / processor: Introduce invalid_phys_cpuid() Hanjun Guo
2015-05-05 11:25   ` Sudeep Holla
2015-05-05 13:14     ` Hanjun Guo
2015-05-11 16:35       ` Lorenzo Pieralisi
2015-05-13  6:39         ` Hanjun Guo
2015-05-06  4:11     ` Hanjun Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430793998-21631-7-git-send-email-hanjun.guo@linaro.org \
    --to=hanjun.guo@linaro.org \
    --cc=Lorenzo.Pieralisi@arm.com \
    --cc=Sudeep.Holla@arm.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=catalin.marinas@arm.com \
    --cc=linaro-acpi@lists.linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®