From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992925AbbEEN6h (ORCPT ); Tue, 5 May 2015 09:58:37 -0400 Received: from mx1.polytechnique.org ([129.104.30.34]:49226 "EHLO mx1.polytechnique.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751840AbbEEN63 (ORCPT ); Tue, 5 May 2015 09:58:29 -0400 From: Nicolas Iooss To: "Paul E. McKenney" , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan Cc: linux-kernel@vger.kernel.org, Nicolas Iooss Subject: [PATCH] rcu: make rcu_*_data variables static Date: Tue, 5 May 2015 21:57:06 +0800 Message-Id: <1430834226-2028-1-git-send-email-nicolas.iooss_linux@m4x.org> X-Mailer: git-send-email 2.3.6 In-Reply-To: <20150505055544.GK5381@linux.vnet.ibm.com> References: <20150505055544.GK5381@linux.vnet.ibm.com> X-AV-Checked: ClamAV using ClamSMTP at svoboda.polytechnique.org (Tue May 5 15:58:26 2015 +0200 (CEST)) X-Spam-Flag: No, tests=bogofilter, spamicity=0.000010, queueID=D4677140912EF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rcu_bh_data, rcu_sched_data and rcu_preempt_data are never used outside kernel/rcu/tree.c and thus can be made static. Doing so fixes a section mismatch warning reported by clang when building LLVMLinux with -Wsection, because these variables were declared in .data..percpu and defined in .data..percpu..shared_aligned since commit 11bbb235c26f ("rcu: Use DEFINE_PER_CPU_SHARED_ALIGNED for rcu_data"). Signed-off-by: Nicolas Iooss --- kernel/rcu/tree.c | 2 +- kernel/rcu/tree.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 233165da782f..e4a607fc5ad0 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -91,7 +91,7 @@ static const char *tp_##sname##_varname __used __tracepoint_string = sname##_var #define RCU_STATE_INITIALIZER(sname, sabbr, cr) \ DEFINE_RCU_TPS(sname) \ -DEFINE_PER_CPU_SHARED_ALIGNED(struct rcu_data, sname##_data); \ +static DEFINE_PER_CPU_SHARED_ALIGNED(struct rcu_data, sname##_data); \ struct rcu_state sname##_state = { \ .level = { &sname##_state.node[0] }, \ .rda = &sname##_data, \ diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h index a69d3dab2ec4..0c32f730d033 100644 --- a/kernel/rcu/tree.h +++ b/kernel/rcu/tree.h @@ -519,14 +519,11 @@ extern struct list_head rcu_struct_flavors; * RCU implementation internal declarations: */ extern struct rcu_state rcu_sched_state; -DECLARE_PER_CPU(struct rcu_data, rcu_sched_data); extern struct rcu_state rcu_bh_state; -DECLARE_PER_CPU(struct rcu_data, rcu_bh_data); #ifdef CONFIG_PREEMPT_RCU extern struct rcu_state rcu_preempt_state; -DECLARE_PER_CPU(struct rcu_data, rcu_preempt_data); #endif /* #ifdef CONFIG_PREEMPT_RCU */ #ifdef CONFIG_RCU_BOOST -- 2.3.6