From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Jean Delvare <jdelvare@suse.de>
Cc: linux-kernel@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH v5 WIP 4/5] i2c-parport: use new parport device model
Date: Wed, 6 May 2015 15:46:16 +0530 [thread overview]
Message-ID: <1430907377-17147-4-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1430907377-17147-1-git-send-email-sudipm.mukherjee@gmail.com>
modify i2c-parport driver to use the new parallel port device model.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/i2c/busses/i2c-parport.c | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-parport.c b/drivers/i2c/busses/i2c-parport.c
index a9b25c3..6db5b45 100644
--- a/drivers/i2c/busses/i2c-parport.c
+++ b/drivers/i2c/busses/i2c-parport.c
@@ -163,6 +163,11 @@ static void i2c_parport_irq(void *data)
"SMBus alert received but no ARA client!\n");
}
+static struct pardev_cb i2c_parport_cb = {
+ .flags = PARPORT_FLAG_EXCL,
+ .irq_func = i2c_parport_irq,
+};
+
static void i2c_parport_attach(struct parport *port)
{
struct i2c_par *adapter;
@@ -184,11 +189,12 @@ static void i2c_parport_attach(struct parport *port)
printk(KERN_ERR "i2c-parport: Failed to kzalloc\n");
return;
}
+ i2c_parport_cb.private = adapter;
pr_debug("i2c-parport: attaching to %s\n", port->name);
parport_disable_irq(port);
- adapter->pdev = parport_register_device(port, "i2c-parport",
- NULL, NULL, i2c_parport_irq, PARPORT_FLAG_EXCL, adapter);
+ adapter->pdev = parport_register_dev_model(port, "i2c-parport",
+ &i2c_parport_cb, i);
if (!adapter->pdev) {
printk(KERN_ERR "i2c-parport: Unable to register with parport\n");
goto err_free;
@@ -281,10 +287,18 @@ static void i2c_parport_detach(struct parport *port)
mutex_unlock(&adapter_list_lock);
}
+static int i2c_parport_probe(struct pardevice *par_dev)
+{
+ if (strcmp(par_dev->name, "i2c-parport"))
+ return -ENODEV;
+ return 0;
+}
+
static struct parport_driver i2c_parport_driver = {
.name = "i2c-parport",
- .attach = i2c_parport_attach,
+ .match_port = i2c_parport_attach,
.detach = i2c_parport_detach,
+ .probe = i2c_parport_probe,
};
/* ----- Module loading, unloading and information ------------------------ */
--
1.8.1.2
next prev parent reply other threads:[~2015-05-06 10:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 10:16 [PATCH v5 WIP 1/5] parport: add device-model to parport subsystem Sudip Mukherjee
2015-05-06 10:16 ` [PATCH v5 WIP 2/5] staging: panel: use new parport device model Sudip Mukherjee
2015-05-19 11:18 ` Dan Carpenter
2015-05-20 8:23 ` Jean Delvare
2015-05-06 10:16 ` [PATCH v5 WIP 3/5] i2c-parport: define ports to connect Sudip Mukherjee
2015-05-19 7:50 ` Jean Delvare
2015-05-19 8:44 ` Sudip Mukherjee
2015-05-19 9:28 ` Jean Delvare
2015-05-19 9:58 ` Sudip Mukherjee
2015-05-19 11:23 ` Dan Carpenter
2015-05-19 12:23 ` Jean Delvare
2015-05-06 10:16 ` Sudip Mukherjee [this message]
2015-05-20 7:57 ` [PATCH v5 WIP 4/5] i2c-parport: use new parport device model Jean Delvare
2015-05-20 8:16 ` Sudip Mukherjee
2015-05-06 10:16 ` [PATCH v5 WIP 5/5] paride: " Sudip Mukherjee
2015-05-19 11:32 ` Dan Carpenter
2015-05-19 12:32 ` Sudip Mukherjee
2015-05-20 8:07 ` Jean Delvare
2015-05-20 8:33 ` Sudip Mukherjee
2015-05-19 11:08 ` [PATCH v5 WIP 1/5] parport: add device-model to parport subsystem Dan Carpenter
2015-05-19 13:18 ` Sudip Mukherjee
2015-05-20 7:54 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430907377-17147-4-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®