From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753093AbbEFRIv (ORCPT ); Wed, 6 May 2015 13:08:51 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:36333 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752752AbbEFRIq (ORCPT ); Wed, 6 May 2015 13:08:46 -0400 From: Ming Lei To: linux-kernel@vger.kernel.org, Dave Kleikamp Cc: Jens Axboe , Zach Brown , Christoph Hellwig , Maxim Patlasov , Andrew Morton , Alexander Viro , Tejun Heo , Ming Lei Subject: [PATCH v3 2/4] block: loop: set QUEUE_FLAG_NOMERGES for request queue of loop Date: Thu, 7 May 2015 01:08:24 +0800 Message-Id: <1430932106-17451-3-git-send-email-ming.lei@canonical.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1430932106-17451-1-git-send-email-ming.lei@canonical.com> References: <1430932106-17451-1-git-send-email-ming.lei@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It doesn't make sense to enable merge because the I/O submitted to backing file is handled page by page. Signed-off-by: Ming Lei --- drivers/block/loop.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 1bee523..e9f563d 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -1572,6 +1572,12 @@ static int loop_add(struct loop_device **l, int i) } lo->lo_queue->queuedata = lo; + /* + * It doesn't make sense to enable merge because the I/O + * submitted to backing file is handled page by page. + */ + queue_flag_set_unlocked(QUEUE_FLAG_NOMERGES, lo->lo_queue); + INIT_LIST_HEAD(&lo->write_cmd_head); INIT_WORK(&lo->write_work, loop_queue_write_work); -- 1.9.1