From: Valdis.Kletnieks@vt.edu
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, yrl.pp-manager.tt@hitachi.com,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 2/4] [TRIVIAL] ftrace/kprobes: Fix an warning typo
Date: Tue, 04 Oct 2011 11:58:03 -0400 [thread overview]
Message-ID: <14310.1317743883@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Tue, 04 Oct 2011 19:44:49 +0900." <20111004104449.14591.16995.stgit@fedora15>
[-- Attachment #1: Type: text/plain, Size: 421 bytes --]
On Tue, 04 Oct 2011 19:44:49 +0900, Masami Hiramatsu said:
> Add a space between words.
> if (ret == -ENOENT && trace_probe_is_on_module(tp)) {
> - pr_warning("This probe might be able to register after"
> + pr_warning("This probe might be able to register after "
> "target module is loaded. Continue.\n");
Better would be to make it all one line. Keeping a string together trumps the
80-column rule.
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2011-10-04 15:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 10:44 [PATCH 1/4] [BUGFIX] ftrace/kprobes: Fix not to delete probes if in use Masami Hiramatsu
2011-10-04 10:44 ` [PATCH 2/4] [TRIVIAL] ftrace/kprobes: Fix an warning typo Masami Hiramatsu
2011-10-04 15:58 ` Valdis.Kletnieks [this message]
2011-10-05 4:08 ` Masami Hiramatsu
2011-10-04 10:44 ` [PATCH 3/4] [TRIVIAL] perftools: Fix a typo of command name as trace-cmd Masami Hiramatsu
2011-10-04 10:45 ` [PATCH 4/4] [BUGFIX] perf probe: Fix to show correct error string Masami Hiramatsu
2011-10-08 5:00 ` [PATCH 1/4] [BUGFIX] ftrace/kprobes: Fix not to delete probes if in use Steven Rostedt
2011-10-10 14:14 ` Masami Hiramatsu
2011-10-10 19:11 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14310.1317743883@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®