From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org
Subject: [PATCH] x86: tell the world boot_params is 16-byte aligned
Date: Fri, 8 May 2015 15:42:33 +0200 [thread overview]
Message-ID: <1431092553-12914-1-git-send-email-linux@rasmusvillemoes.dk> (raw)
It doesn't matter much, but this disassembly makes me cry a little bit:
ffffffff81f21223 <copy_bootdata>:
ffffffff81f21223: 55 push %rbp
ffffffff81f21224: 48 c7 c0 40 c2 02 82 mov $0xffffffff8202c240,%rax
ffffffff81f2122b: 48 89 fe mov %rdi,%rsi
ffffffff81f2122e: a8 01 test $0x1,%al
The reason is that boot_params is defined with
__attribute__((aligned(16))) in boot/main.c, but other translation
units only see the packed attribute on the definition of struct
boot_params, so assume the worst. Making the de facto alignment public
has this effect:
$ scripts/bloat-o-meter /tmp/vmlinux.{defconfig,align}
add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-230 (-230)
function old new delta
copy_bootdata 444 214 -230
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
arch/x86/include/asm/setup.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/setup.h b/arch/x86/include/asm/setup.h
index f69e06b283fb..dcd6d5fc2f12 100644
--- a/arch/x86/include/asm/setup.h
+++ b/arch/x86/include/asm/setup.h
@@ -64,7 +64,7 @@ static inline void x86_ce4100_early_setup(void) { }
/*
* This is set up by the setup-routine at boot-time
*/
-extern struct boot_params boot_params;
+extern struct boot_params boot_params __attribute__((aligned(16)));
static inline bool kaslr_enabled(void)
{
--
2.1.3
next reply other threads:[~2015-05-08 13:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 13:42 Rasmus Villemoes [this message]
2015-05-08 14:24 ` Borislav Petkov
2015-05-08 16:23 ` Rasmus Villemoes
2015-05-08 16:26 ` H. Peter Anvin
2015-05-08 17:40 ` Borislav Petkov
2015-05-08 18:36 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431092553-12914-1-git-send-email-linux@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®