mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: He Kuang <hekuang@huawei.com>
To: <masami.hiramatsu.pt@hitachi.com>, <a.p.zijlstra@chello.nl>,
	<acme@kernel.org>, <jolsa@kernel.org>, <mingo@redhat.com>
Cc: <wangnan0@huawei.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 3/3] perf probe: Show better error message when failed to find variable
Date: Sat, 9 May 2015 09:55:06 +0000	[thread overview]
Message-ID: <1431165306-106463-3-git-send-email-hekuang@huawei.com> (raw)
In-Reply-To: <1431165306-106463-1-git-send-email-hekuang@huawei.com>

Indicate to check variable location range in error message when we got
failed to find the variable.

Before this patch:

  $ perf probe --add 'generic_perform_write+118 bytes'
  Failed to find the location of bytes at this address.
   Perhaps, it has been optimized out.
    Error: Failed to add events.

After this patch:
  $ perf probe --add 'generic_perform_write+118 bytes'
  Failed to find the location of bytes at this address.
   Perhaps, it has been optimized out.
   Use -V with --range option to show variable location range.
    Error: Failed to add events.

Signed-off-by: He Kuang <hekuang@huawei.com>
---
 tools/perf/util/probe-finder.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
index 30a1a1b..2b91323 100644
--- a/tools/perf/util/probe-finder.c
+++ b/tools/perf/util/probe-finder.c
@@ -532,7 +532,9 @@ static int convert_variable(Dwarf_Die *vr_die, struct probe_finder *pf)
 					&pf->sp_die, pf->tvar);
 	if (ret == -ENOENT || ret == -EINVAL)
 		pr_err("Failed to find the location of %s at this address.\n"
-		       " Perhaps, it has been optimized out.\n", pf->pvar->var);
+		       " Perhaps, it has been optimized out.\n"
+		       " Use -V with --range option to show variable location range.\n",
+		       pf->pvar->var);
 	else if (ret == -ENOTSUP)
 		pr_err("Sorry, we don't support this variable location yet.\n");
 	else if (ret == 0 && pf->pvar->field) {
-- 
1.8.5.2


  parent reply	other threads:[~2015-05-09  9:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-09  9:55 [PATCH v2 1/3] perf probe: Remove length limitation for showing available variables He Kuang
2015-05-09  9:55 ` [PATCH v2 2/3] perf probe: Add --range option to show variable location range He Kuang
2015-05-10  3:21   ` Masami Hiramatsu
2015-05-11  2:22     ` He Kuang
2015-05-11  6:03       ` Masami Hiramatsu
2015-05-09  9:55 ` He Kuang [this message]
2015-05-10  3:23   ` [PATCH v2 3/3] perf probe: Show better error message when failed to find variable Masami Hiramatsu
2015-05-10  3:23 ` [PATCH v2 1/3] perf probe: Remove length limitation for showing available variables Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431165306-106463-3-git-send-email-hekuang@huawei.com \
    --to=hekuang@huawei.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®