From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751958AbbEIU11 (ORCPT ); Sat, 9 May 2015 16:27:27 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:35165 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751129AbbEIU1Z (ORCPT ); Sat, 9 May 2015 16:27:25 -0400 From: Arno Tiemersma To: gregkh@linuxfoundation.org, mateusz.kulikowski@gmail.com, behanw@converseincode.com, mdcasey@chabloom.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Cc: Arno Tiemersma Subject: [PATCH v2] staging: rtl8192e: Change cpu_to_le16 to le16_to_cpu Date: Sat, 9 May 2015 22:27:16 +0200 Message-Id: <1431203236-5895-1-git-send-email-arno.tiemersma@gmail.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since the function auth_parse returns a u16, and struct rtllib_authentication.status is defined as an __le16, it seems that return cpu_to_le16(a->status); should be return le16_to_cpu(a->status); This change silences the following sparse warnings: drivers/staging/rtl8192e/rtllib_softmac.c:1817:16: warning: cast from restricted __le16 drivers/staging/rtl8192e/rtllib_softmac.c:1817:16: warning: incorrect type in return expression (different base types) drivers/staging/rtl8192e/rtllib_softmac.c:1817:16: expected unsigned short drivers/staging/rtl8192e/rtllib_softmac.c:1817:16: got restricted __le16 [usertype] Signed-off-by: Arno Tiemersma --- v2 since I did not have the right e-mail address for Mateusz Kulikowski drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c index 8f5e88b..98afd3b 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac.c +++ b/drivers/staging/rtl8192e/rtllib_softmac.c @@ -1814,7 +1814,7 @@ static inline u16 auth_parse(struct sk_buff *skb, u8 **challenge, int *chlen) return -ENOMEM; } } - return cpu_to_le16(a->status); + return le16_to_cpu(a->status); } static int auth_rq_parse(struct sk_buff *skb, u8 *dest) -- 2.1.4