mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: acme@kernel.org
Cc: jolsa@redhat.com, linux-kernel@vger.kernel.org,
	namhyung@kernel.org, eranian@google.com,
	Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 10/10] test patch: Add fake branch cycles to input data in report/top
Date: Sun, 10 May 2015 06:52:06 -0700	[thread overview]
Message-ID: <1431265926-4766-11-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1431265926-4766-1-git-send-email-andi@firstfloor.org>

From: Andi Kleen <ak@linux.intel.com>

Not to be merged, but useful for testing if you don't have
hardware with cycles branch stack support.
---
 tools/perf/util/hist.c    | 2 +-
 tools/perf/util/machine.c | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index cf6b48b..8acac89 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -1418,7 +1418,7 @@ void hist__account_cycles(struct branch_stack *bs, struct addr_location *al,
 	struct branch_info *bi;
 
 	/* If we have branch cycles always annotate them. */
-	if (bs && bs->nr && bs->entries[0].flags.cycles) {
+	if (bs && bs->nr /* && bs->entries[0].flags.cycles */) {
 		int i;
 
 		bi = sample__resolve_bstack(sample, al);
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index 2f47110..72edc4e 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -1498,6 +1498,8 @@ struct branch_info *sample__resolve_bstack(struct perf_sample *sample,
 		ip__resolve_ams(al->thread, &bi[i].to, bs->entries[i].to);
 		ip__resolve_ams(al->thread, &bi[i].from, bs->entries[i].from);
 		bi[i].flags = bs->entries[i].flags;
+		if (bi[i].flags.cycles == 0)
+			bi[i].flags.cycles = 123;
 	}
 	return bi;
 }
-- 
1.9.3


  parent reply	other threads:[~2015-05-10 13:52 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-10 13:51 Cycles annotation support for perf tools Andi Kleen
2015-05-10 13:51 ` [PATCH 01/10] perf, tools: Add tools support for cycles, weight branch_info field Andi Kleen
2015-05-10 13:51 ` [PATCH 02/10] perf, tools, report: Add flag for non ANY branch mode Andi Kleen
2015-05-10 13:51 ` [PATCH 03/10] perf, tools, report: Add infrastructure for a cycles histogram Andi Kleen
2015-05-10 13:52 ` [PATCH 04/10] perf, tools, report: Add processing for cycle histograms Andi Kleen
2015-05-26 10:09   ` Jiri Olsa
2015-05-26 17:37     ` Andi Kleen
2015-06-01 13:02       ` Jiri Olsa
2015-06-01 13:07         ` Andi Kleen
2015-05-10 13:52 ` [PATCH 05/10] perf, tools: Compute IPC and basic block cycles for annotate Andi Kleen
2015-05-10 13:52 ` [PATCH 06/10] perf, tools, annotate: Finally display IPC and cycle accounting Andi Kleen
2015-05-10 13:52 ` [PATCH 07/10] perf, tools, report: Move branch option parsing to own file Andi Kleen
2015-05-26 10:09   ` Jiri Olsa
2015-05-10 13:52 ` [PATCH 08/10] perf, tools, top: Add branch annotation code to top Andi Kleen
2015-05-10 13:52 ` [PATCH 09/10] perf, tools, report: Display cycles in branch sort mode Andi Kleen
2015-05-10 13:52 ` Andi Kleen [this message]
2015-05-18 19:06 ` Cycles annotation support for perf tools Andi Kleen
2015-05-19  9:55   ` Jiri Olsa
2015-05-24 18:55 ` Jiri Olsa
2015-05-24 19:19   ` Andi Kleen
2015-05-26 10:08 ` Jiri Olsa
2015-05-26 16:56   ` Andi Kleen
2015-05-26 21:40     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431265926-4766-11-git-send-email-andi@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®