mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicholas Mc Guire <hofrat@osadl.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Josh Triplett <josh@joshtriplett.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Lai Jiangshan <laijs@cn.fujitsu.com>,
	linux-kernel@vger.kernel.org,
	Nicholas Mc Guire <hofrat@osadl.org>
Subject: [PATCH V2] rcu: change function declaration to bool
Date: Mon, 11 May 2015 17:10:59 +0200	[thread overview]
Message-ID: <1431357059-29795-1-git-send-email-hofrat@osadl.org> (raw)

rcu_cpu_has_callbacks() is declared int but is actually returning bool and
and as the function description states " * Return true if the specified 
CPU has any callback....", this probably should be a bool. All (3) 
call-sites currently treat it as bool so the declaration.


Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---

V2: fixed up commit message and tool infos as requested by 
    Josh Triplett <josh@joshtriplett.org>

Type-checking coccinelle spatches are being used to locate type 
mismatches between function signatures and return values. 
./kernel/rcu/tree.c:3538 WARNING: return of wrong type
                    int != bool, 

Patch was compile tested with x86_64_defconfig (implies CONFIG_TREE_RCU=y)

Patch is against 4.1-rc3 (localversion-next is -next-20150511)

 kernel/rcu/tree.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index bcc5943..599550c 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -3516,7 +3516,7 @@ static int rcu_pending(void)
  * non-NULL, store an indication of whether all callbacks are lazy.
  * (If there are no callbacks, all of them are deemed to be lazy.)
  */
-static int __maybe_unused rcu_cpu_has_callbacks(bool *all_lazy)
+static bool __maybe_unused rcu_cpu_has_callbacks(bool *all_lazy)
 {
 	bool al = true;
 	bool hc = false;
-- 
1.7.10.4


             reply	other threads:[~2015-05-11 15:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 15:10 Nicholas Mc Guire [this message]
2015-05-11 15:28 ` Steven Rostedt
2015-05-11 15:37   ` Josh Triplett
2015-05-11 15:45     ` Nicholas Mc Guire
2015-05-11 15:59       ` Steven Rostedt
2015-05-11 16:21         ` Nicholas Mc Guire
2015-05-11 15:46 Nicholas Mc Guire
2015-05-11 16:11 ` Josh Triplett
2015-05-11 16:58   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431357059-29795-1-git-send-email-hofrat@osadl.org \
    --to=hofrat@osadl.org \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®