From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752415AbbEKPhQ (ORCPT ); Mon, 11 May 2015 11:37:16 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:36530 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbbEKPhO (ORCPT ); Mon, 11 May 2015 11:37:14 -0400 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: [PATCH v2 5/3] perf report: Check attr.inherit_stat bit for --show-threads Date: Tue, 12 May 2015 00:35:57 +0900 Message-Id: <1431358557-31823-1-git-send-email-namhyung@kernel.org> X-Mailer: git-send-email 2.4.0 In-Reply-To: <1431352171-1057-1-git-send-email-namhyung@kernel.org> References: <1431352171-1057-1-git-send-email-namhyung@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Check the evsel->attr.inherit_stat bit and show warning message if it's missing and -T/--threads option was given: $ perf report -T Error: perf.data file has no per-thread stat data. Did you run 'perf record' with -s option? Suggested-by: David Ahern Signed-off-by: Namhyung Kim --- Move error message before header info message tools/perf/builtin-report.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 6ac2c7a01a63..343cca2a2779 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -833,6 +833,19 @@ repeat: } } + if (report.show_threads) { + struct perf_evsel *evsel; + + evlist__for_each(session->evlist, evsel) { + if (!evsel->attr.inherit_stat) { + pr_err("Error: %s file has no per-thread stat data.\n" + " Did you run 'perf record' with -s option?\n", + input_name); + goto error; + } + } + } + if (strcmp(input_name, "-") != 0) setup_browser(true); else -- 2.4.0