mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Henrie <alexhenrie24@gmail.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	Kees Cook <keescook@chromium.org>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Doug Johnson <dougvj@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Tyler Hicks <tyhicks@canonical.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-kernel@vger.kernel.org
Cc: Alex Henrie <alexhenrie24@gmail.com>
Subject: [PATCH v2] x86: Preserve iopl on fork and execve
Date: Mon, 11 May 2015 17:38:25 -0600	[thread overview]
Message-ID: <1431387505-13410-1-git-send-email-alexhenrie24@gmail.com> (raw)

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Suggested-by: Doug Johnson <dougvj@dougvj.net>
---
 arch/x86/kernel/process_32.c | 2 +-
 arch/x86/kernel/process_64.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/process_32.c b/arch/x86/kernel/process_32.c
index 8ed2106..0ef7078 100644
--- a/arch/x86/kernel/process_32.c
+++ b/arch/x86/kernel/process_32.c
@@ -205,7 +205,7 @@ start_thread(struct pt_regs *regs, unsigned long new_ip, unsigned long new_sp)
 	regs->cs		= __USER_CS;
 	regs->ip		= new_ip;
 	regs->sp		= new_sp;
-	regs->flags		= X86_EFLAGS_IF;
+	regs->flags		= X86_EFLAGS_IF | (X86_EFLAGS_IOPL & regs->flags);
 	force_iret();
 }
 EXPORT_SYMBOL_GPL(start_thread);
diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
index ddfdbf7..e21eda2 100644
--- a/arch/x86/kernel/process_64.c
+++ b/arch/x86/kernel/process_64.c
@@ -238,7 +238,7 @@ start_thread_common(struct pt_regs *regs, unsigned long new_ip,
 	regs->sp		= new_sp;
 	regs->cs		= _cs;
 	regs->ss		= _ss;
-	regs->flags		= X86_EFLAGS_IF;
+	regs->flags		= X86_EFLAGS_IF | (X86_EFLAGS_IOPL & regs->flags);
 	force_iret();
 }
 
-- 
2.4.0


             reply	other threads:[~2015-05-11 23:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 23:38 Alex Henrie [this message]
2015-05-12  6:40 ` Ingo Molnar
2015-05-12 15:13   ` Linus Torvalds
2015-05-12 18:24     ` H. Peter Anvin
2015-05-12 15:24   ` Arjan van de Ven
2015-05-12 15:25     ` Arjan van de Ven
2015-05-12 15:47       ` Austin S Hemmelgarn
2015-05-12 18:05         ` Alex Henrie
2015-05-12 18:12           ` Austin S Hemmelgarn
2015-05-14 10:41       ` Josh Triplett
2015-05-15  0:52         ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431387505-13410-1-git-send-email-alexhenrie24@gmail.com \
    --to=alexhenrie24@gmail.com \
    --cc=dougvj@gmail.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tyhicks@canonical.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®