From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753629AbbEMGzF (ORCPT ); Wed, 13 May 2015 02:55:05 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:38283 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753379AbbEMGzA (ORCPT ); Wed, 13 May 2015 02:55:00 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-08-5552f540e8fd From: Krzysztof Kozlowski To: Tero Kristo , Mike Turquette , Stephen Boyd , linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , stable@vger.kernel.org Subject: [RFT PATCH 1/8] clk: ti: dra7-atl-clock: Fix possible ERR_PTR dereference Date: Wed, 13 May 2015 15:54:40 +0900 Message-id: <1431500087-2275-2-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1431500087-2275-1-git-send-email-k.kozlowski@samsung.com> References: <1431500087-2275-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOLMWRmVeSWpSXmKPExsVy+t/xa7oOX4NCDdqXWVu8fmFo8bHnHqvF 5V1z2CxmL+lnsXg64SKbxY8z3SwWCzY+YrRY8rSDzYHD43JfL5PHnWt72Dz6tqxi9Dh+YzuT x+dNcgGsUVw2Kak5mWWpRfp2CVwZD1+tYCw4xFGxvGU6awNjG3sXIyeHhICJxIH5d6BsMYkL 99azdTFycQgJLGWU+DpzOSuE859RYuHC78wgVWwCxhKbly8BqxIROM4osWJPP1g7s4CnxLu/ D8FsYYEQiU0ty5hAbBYBVYnWe1/BmnkF3CTaHz5kgVgnJ3Hy2GSgDRwcnALuEpfmiYGYQkAl +xrqJjDyLmBkWMUomlqaXFCclJ5rqFecmFtcmpeul5yfu4kRElxfdjAuPmZ1iFGAg1GJh3fG 28BQIdbEsuLK3EOMEhzMSiK8S98FhQrxpiRWVqUW5ccXleakFh9ilOZgURLnnbvrfYiQQHpi SWp2ampBahFMlomDU6qBseZNx7bdXS3XVLwWqTr8yNtZLd4seKLjwhKffZefZu9RCLu+dsFx 5djLuneTJwke+D9j+2WPi5W71Fc/T/R2Fxdg4+9hVTjzyt2lISx3/fQvxikB/j6T2jTeXrWu eM/lFlgZt36Kj7TRGeUKI+kFAUsfPOc0maJcKn7/+fNutqYT3veXhibnKbEUZyQaajEXFScC AAJrt2kqAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_clk_get_from_provider() returns ERR_PTR on failure. The dra7-atl-clock driver was not checking its return value and immediately used it in __clk_get_hw(). __clk_get_hw() dereferences supplied clock, if it is not NULL, so in that case it would dereference an ERR_PTR. Signed-off-by: Krzysztof Kozlowski Cc: Fixes: 9ac33b0ce81f ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)") --- drivers/clk/ti/clk-dra7-atl.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c index d86bc46b93bd..0a1df821860f 100644 --- a/drivers/clk/ti/clk-dra7-atl.c +++ b/drivers/clk/ti/clk-dra7-atl.c @@ -252,6 +252,11 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev) } clk = of_clk_get_from_provider(&clkspec); + if (IS_ERR(clk)) { + pr_err("%s: failed to get atl clock %d from provider\n", + __func__, i); + return PTR_ERR(clk); + } cdesc = to_atl_desc(__clk_get_hw(clk)); cdesc->cinfo = cinfo; -- 1.9.1