From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933568AbbENO0L (ORCPT ); Thu, 14 May 2015 10:26:11 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:35834 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933060AbbENO0I (ORCPT ); Thu, 14 May 2015 10:26:08 -0400 From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] staging: rts5208: remove always true comparison Date: Thu, 14 May 2015 19:55:59 +0530 Message-Id: <1431613559-17097-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org the if comparison is always true as anything bitwise and-ing with 0x1E can never be equal to 0x03. Fixes bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=69881 Reported-by: David Binderman Signed-off-by: Sudip Mukherjee --- drivers/staging/rts5208/sd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c index a8d657b..2e3f1f4 100644 --- a/drivers/staging/rts5208/sd.c +++ b/drivers/staging/rts5208/sd.c @@ -4170,10 +4170,8 @@ RTY_SEND_CMD: } } else if (rsp_type == SD_RSP_TYPE_R0) { - if ((ptr[3] & 0x1E) != 0x03) { - rtsx_trace(chip); - return STATUS_FAIL; - } + rtsx_trace(chip); + return STATUS_FAIL; } } } -- 1.8.1.2