From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934846AbbEOP63 (ORCPT ); Fri, 15 May 2015 11:58:29 -0400 Received: from smtprelay0022.hostedemail.com ([216.40.44.22]:35841 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753478AbbEOP62 (ORCPT ); Fri, 15 May 2015 11:58:28 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:4250:4321:5007:6119:6261:10004:10400:10848:11026:11232:11658:11914:12296:12517:12519:12740:13069:13311:13357:21080:21088,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: cook58_4998c32dc0829 X-Filterd-Recvd-Size: 1492 Message-ID: <1431705504.15709.8.camel@perches.com> Subject: Re: [PATCHiv5 1/1] RTC:driver for Cortina's SOC From: Joe Perches To: Hans Ulli Kroll Cc: Alexandre Belloni , linux-kernel@vger.kernel.org, Paul Bolle , Arnd Bergmann , Geert Uytterhoeven Date: Fri, 15 May 2015 08:58:24 -0700 In-Reply-To: <1431703736-18162-2-git-send-email-ulli.kroll@googlemail.com> References: <1431703736-18162-1-git-send-email-ulli.kroll@googlemail.com> <1431703736-18162-2-git-send-email-ulli.kroll@googlemail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-05-15 at 17:28 +0200, Hans Ulli Kroll wrote: > Driver for the on chip RTC found on Cortina's SoC Gemini. Trivia: > diff --git a/drivers/rtc/rtc-gemini.c b/drivers/rtc/rtc-gemini.c [] > +static int gemini_rtc_probe(struct platform_device *pdev) > +{ > + struct gemini_rtc *rtc; > + struct device *dev = &pdev->dev; > + struct resource *res; > + int ret; > + > + rtc = kzalloc(sizeof(*rtc), GFP_KERNEL); this could/should be devm_kzalloc