mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@kernel.org>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, Pekka Enberg <penberg@kernel.org>,
	"Nicholas A. Bellinger" <nab@linux-iscsi.org>
Subject: [PATCH 10/14] target: Use kvfree() in session alloc and free
Date: Fri, 15 May 2015 21:35:19 +0300	[thread overview]
Message-ID: <1431714923-23028-10-git-send-email-penberg@kernel.org> (raw)
In-Reply-To: <1431714923-23028-1-git-send-email-penberg@kernel.org>

Use kvfree() instead of open-coding it.

Cc: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
---
 drivers/target/target_core_transport.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index 3fe5cb2..9c058c0 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -280,10 +280,7 @@ int transport_alloc_session_tags(struct se_session *se_sess,
 	if (rc < 0) {
 		pr_err("Unable to init se_sess->sess_tag_pool,"
 			" tag_num: %u\n", tag_num);
-		if (is_vmalloc_addr(se_sess->sess_cmd_map))
-			vfree(se_sess->sess_cmd_map);
-		else
-			kfree(se_sess->sess_cmd_map);
+		kvfree(se_sess->sess_cmd_map);
 		se_sess->sess_cmd_map = NULL;
 		return -ENOMEM;
 	}
@@ -490,10 +487,7 @@ void transport_free_session(struct se_session *se_sess)
 {
 	if (se_sess->sess_cmd_map) {
 		percpu_ida_destroy(&se_sess->sess_tag_pool);
-		if (is_vmalloc_addr(se_sess->sess_cmd_map))
-			vfree(se_sess->sess_cmd_map);
-		else
-			kfree(se_sess->sess_cmd_map);
+		kvfree(se_sess->sess_cmd_map);
 	}
 	kmem_cache_free(se_sess_cache, se_sess);
 }
-- 
2.1.0


  parent reply	other threads:[~2015-05-15 18:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-15 18:35 [PATCH 01/14] ipc/util.c: Use kvfree() in ipc_rcu_free() Pekka Enberg
2015-05-15 18:35 ` [PATCH 02/14] kernel/relay.c: Use kvfree() in relay_free_page_array() Pekka Enberg
2015-05-15 18:35 ` [PATCH 03/14] cxgb3: Use kvfree() in cxgb_free_mem() Pekka Enberg
2015-05-15 18:35 ` [PATCH 04/14] cxgb4: Use kvfree() in t4_free_mem() Pekka Enberg
2015-05-15 18:35 ` [PATCH 05/14] ceph: Use kvfree() in ceph_put_page_vector() Pekka Enberg
2015-05-18  5:45   ` Yan, Zheng
2015-05-18  6:58   ` Yan, Zheng
2015-05-18  6:59   ` Yan, Zheng
2015-05-15 18:35 ` [PATCH 06/14] drm: Use kvfree() in drm_free_large() Pekka Enberg
2015-05-15 18:35 ` [PATCH 07/14] drm/nouveau/gem: Use kvfree() in u_free() Pekka Enberg
2015-05-15 18:35 ` [PATCH 08/14] drivers/input/evdev.c: Use kvfree() in evdev_release() Pekka Enberg
2015-05-15 20:46   ` Dmitry Torokhov
2015-05-15 18:35 ` [PATCH 09/14] IB/ehca: Use kvfree() in ipz_queue_{cd}tor() Pekka Enberg
2015-05-15 18:35 ` Pekka Enberg [this message]
2015-05-15 18:35 ` [PATCH 11/14] libcxgbi: Use kvfree() in cxgbi_free_big_mem() Pekka Enberg
2015-05-15 18:35 ` [PATCH 12/14] dm: Use kvfree() in dm_kvfree() Pekka Enberg
2015-05-15 19:19   ` Mike Snitzer
2015-05-15 18:35 ` [PATCH 13/14] bcache: Use kvfree() in various places Pekka Enberg
2015-05-15 18:35 ` [PATCH 14/14] NTFS: Use kvfree() in ntfs_free() Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431714923-23028-10-git-send-email-penberg@kernel.org \
    --to=penberg@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome