From: Adrian Remonda <adrianremonda@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Adrian Remonda <adrianremonda@gmail.com>,
Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Joe Perches <joe@perches.com>, Greg Donald <gdonald@gmail.com>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Tristan Lelong <tristan@lelong.xyz>,
Omar Sandoval <osandov@osandov.com>,
HPDD-discuss@ml01.01.org (moderated list:STAGING - LUSTRE...),
devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 2/4] Staging: lustre: sparse static warning fix
Date: Mon, 18 May 2015 20:34:49 +0200 [thread overview]
Message-ID: <1431974091-26363-3-git-send-email-adrianremonda@gmail.com> (raw)
In-Reply-To: <1431974091-26363-2-git-send-email-adrianremonda@gmail.com>
This patch clears the warning given by sparse that the function should be static.
Done by moving the declaration of the structure 'nrs_core' into the header
'ptlrpc_internal.h'
modified: drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
modified: drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h
Signed-off-by: Adrian Remonda <adrianremonda@gmail.com>
---
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 6 ------
drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 7 +++++++
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
index aeceef5152ac..300310e064f5 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
@@ -417,12 +417,6 @@ ptlrpc_lprocfs_threads_max_seq_write(struct file *file,
LPROC_SEQ_FOPS(ptlrpc_lprocfs_threads_max);
/**
- * \addtogoup nrs
- * @{
- */
-extern struct nrs_core nrs_core;
-
-/**
* Translates \e ptlrpc_nrs_pol_state values to human-readable strings.
*
* \param[in] state The policy state
diff --git a/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h b/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h
index e07e2aacc62c..f9bfcff2ac9b 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h
+++ b/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h
@@ -313,4 +313,11 @@ static inline void ptlrpc_reqset_put(struct ptlrpc_request_set *set)
/* ptlrpc/nrs_fifo.c */
extern struct ptlrpc_nrs_pol_conf nrs_conf_fifo;
+/**
+ * \addtogoup nrs
+ * @{
+ */
+extern struct nrs_core nrs_core;
+
+
#endif /* PTLRPC_INTERNAL_H */
--
2.1.4
next prev parent reply other threads:[~2015-05-18 18:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1431974091-26363-1-git-send-email-adrianremonda@gmail.com>
2015-05-18 18:34 ` [PATCH 1/4] " Adrian Remonda
2015-05-18 18:34 ` Adrian Remonda [this message]
2015-05-18 18:34 ` [PATCH 3/4] Staging: lustre: Fixed typo Adrian Remonda
2015-05-18 18:34 ` [PATCH 4/4] Staging: lustre: sparse lock warning fix Adrian Remonda
2015-05-18 21:21 ` Dan Carpenter
2015-05-20 16:51 ` Dilger, Andreas
2015-05-20 19:29 ` Dan Carpenter
2015-05-20 19:42 ` Dan Carpenter
2015-05-20 22:51 ` Dilger, Andreas
2015-05-22 13:38 ` Dan Carpenter
2015-05-21 8:15 ` AdrianRemonda
2015-05-21 15:12 ` Dan Carpenter
2015-05-21 15:33 ` Drokin, Oleg
2015-05-22 1:11 ` Nikitas Angelinas
2015-05-18 21:23 ` [PATCH 1/4] Staging: lustre: sparse static " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431974091-26363-3-git-send-email-adrianremonda@gmail.com \
--to=adrianremonda@gmail.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=Julia.Lawall@lip6.fr \
--cc=andreas.dilger@intel.com \
--cc=aysemelikeyurtoglu@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=osandov@osandov.com \
--cc=tristan@lelong.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®