From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932711AbbERTkH (ORCPT ); Mon, 18 May 2015 15:40:07 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:34834 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932329AbbERTkF (ORCPT ); Mon, 18 May 2015 15:40:05 -0400 Message-ID: <1431985821.9328.16.camel@pedrito-laptop> Subject: Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt_wep.c From: pmarzo To: Sudip Mukherjee Cc: gregkh@linuxfoundation.org, navyasri.tech@gmail.com, dilekuzulmez@gmail.com, joe@perches.com, haticeerturk27@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 18 May 2015 23:50:21 +0200 In-Reply-To: <20150518162331.GA12138@sudip-PC> References: <1431970583-14204-1-git-send-email-marzo.pedro@gmail.com> <20150518162331.GA12138@sudip-PC> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.10.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-05-18 at 21:53 +0530, Sudip Mukherjee wrote: > On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote: > > Merge two pr_debug lines with literal strings splitted across several lines > > into one single line, simplifying prism2_wep_init error check code. > > Openning braces should never be in a new line, move them to the end of > > the previous line. > > Removed two useless lines at ieee80211_wep_null. > > Like Joe Perches said in your last patch - you are doing too many things > in a single patch. break it into separate patches each doing a single > change. > Agree > > > > Signed-off-by: Pedro Marzo Perez > > --- > > .../rtl8192u/ieee80211/ieee80211_crypt_wep.c | 33 ++++++++-------------- > > 1 file changed, 12 insertions(+), 21 deletions(-) > > > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > > index 0a17f84..1074916 100644 > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > > @@ -9,6 +9,8 @@ > > * more details. > > */ > > > > > - > > + pr_debug(pr_fmt("could not allocate crypto API arc4\n")); > this is not right. Completely agree Will be fixed at v3 > > regards > sudip