From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754093AbbERVqw (ORCPT ); Mon, 18 May 2015 17:46:52 -0400 Received: from mail-wg0-f54.google.com ([74.125.82.54]:34081 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752460AbbERVqu (ORCPT ); Mon, 18 May 2015 17:46:50 -0400 Message-ID: <1431993427.9328.29.camel@pedrito-laptop> Subject: Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt_wep.c From: pmarzo To: Dan Carpenter Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, haticeerturk27@gmail.com, linux-kernel@vger.kernel.org, joe@perches.com, dilekuzulmez@gmail.com, navyasri.tech@gmail.com Date: Tue, 19 May 2015 01:57:07 +0200 In-Reply-To: <20150518210615.GJ22558@mwanda> References: <1431970583-14204-1-git-send-email-marzo.pedro@gmail.com> <20150518161531.GI22558@mwanda> <1431986168.9328.22.camel@pedrito-laptop> <20150518210615.GJ22558@mwanda> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.10.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-05-19 at 00:06 +0300, Dan Carpenter wrote: > On Mon, May 18, 2015 at 11:56:08PM +0200, pmarzo wrote: > > On Mon, 2015-05-18 at 19:15 +0300, Dan Carpenter wrote: > > > On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote: > > > > Merge two pr_debug lines with literal strings splitted across several lines > > > > into one single line, simplifying prism2_wep_init error check code. > > > > Openning braces should never be in a new line, move them to the end of > > > > the previous line. > > > > Removed two useless lines at ieee80211_wep_null. > > > > > > > > > > When Joe said "Some will say this is doing too many things in a single > > > patch." he meant Greg. Break this up into multiple patches. Especially > > > now that you've added even more stuff to it. > > > > > > regards, > > > dan carpenter > > > > Sorry Joe, English is not my mother tongue and I misunderstand your > > comment, I thought "Some will say this is doing too many things in a > > single patch" did meant "You are on the limit, but it is ok to send it > > in one patch" but I see it really means "please, rewrite this whole crap > > into several patches" :-) > > The line is a fuzzy line. You were maybe on the line, maybe but then > you crossed over. Indeed I did, but this was mainly Joe's fault for giving good ideas about how to refactor the code. Joe,next time be quiet please :-) > > > > > So I guess an v3 patch should be a chain of several patches, I think a > > sensible approach would be three patches > > 1/3 => rewrite of the error check code > > 2/3 => remove of the two useless lines at ieee80211_wep_null. > > 3/3 => move openning braces and correct the indentation of the > > #include > > > > What do you think about it? > > That sounds fine. Ok! > > regards, > dan carpenter regards, Pedro.