From: Wang Long <long.wanglong@huawei.com>
To: <rostedt@goodmis.org>, <jkosina@suse.cz>, <pmladek@suse.cz>,
<gregkh@linuxfoundation.org>
Cc: <stable@vger.kernel.org>, <wanglong@laoqinren.net>,
<peifeiyue@huawei.com>, <linux-kernel@vger.kernel.org>,
<paulmck@linux.vnet.ibm.com>, <dzickus@redhat.com>,
<x86@kernel.org>, <long.wanglong@huawei.com>,
<morgan.wang@huawei.com>, <sasha.levin@oracle.com>
Subject: [PATCH v2 00/17] [request for stable 3.10 inclusion] x86/nmi: Print all cpu stacks from NMI safely
Date: Tue, 19 May 2015 09:08:45 +0000 [thread overview]
Message-ID: <1432026542-123571-1-git-send-email-long.wanglong@huawei.com> (raw)
This is my backport patch series to Fix the problem(backport to 3.10):
"
When trigger_all_cpu_backtrace() is called on x86, it will trigger an
NMI on each CPU and call show_regs(). But this can lead to a hard lock
up if the NMI comes in on another printk().
"
The solution is described in commit "a9edc88093287183ac934be44f295f183b2c62dd":
when the NMI triggers, it switches the printk routine for that CPU to call
a NMI safe printk function that records the printk in a per_cpu seq_buf
descriptor. After all NMIs have finished recording its data, the trace_
seqs are printed in a safe context.
The solution use "switch printk routine" and "seq_buf" infrastructures, but the
3.10 stable have no both of them.
The patch 1-13 backport the "seq_buf" infrastructures. in detail, patch 1, 2
and 6 only backport "seq_buf" related code.
The patch 14-15 backport the "switch printk routine".
The patch 16-17 is the patch to print all cpu stacks from NMI safely
as discussed in https://lkml.org/lkml/2015/5/13/497, in 3.10 stable, this is
the only way to solve the problem and the backport code is a bit more.
v1 -> v2:
* fix the indent error.
* rebase on 3.10.79
Any thoughts?
Sasha Levin (1):
x86/nmi: Fix use of unallocated cpumask_var_t
Steven Rostedt (Red Hat) (16):
tracing: Create seq_buf layer in trace_seq
tracing: Convert seq_buf_path() to be like seq_path()
tracing: Convert seq_buf fields to be like seq_file fields
tracing: Add a seq_buf_clear() helper and clear len and readpos in
init
seq_buf: Create seq_buf_used() to find out how much was written
tracing: Use trace_seq_used() and seq_buf_used() instead of len
seq_buf: Add seq_buf_can_fit() helper function
tracing: Have seq_buf use full buffer
tracing: Add seq_buf_get_buf() and seq_buf_commit() helper functions
seq-buf: Make seq_buf_bprintf() conditional on CONFIG_BINARY_PRINTF
seq_buf: Move the seq_buf code to lib/
seq_buf: Fix seq_buf_vprintf() truncation
seq_buf: Fix seq_buf_bprintf() truncation
printk: Add per_cpu printk func to allow printk to be diverted
printk/percpu: Define printk_func when printk is not defined
x86/nmi: Perform a safe NMI stack trace on all CPUs
arch/x86/kernel/apic/hw_nmi.c | 86 +++++++++-
include/linux/percpu.h | 4 +
include/linux/printk.h | 2 +
include/linux/seq_buf.h | 136 ++++++++++++++++
kernel/printk.c | 41 +++--
lib/Makefile | 2 +-
lib/seq_buf.c | 359 ++++++++++++++++++++++++++++++++++++++++++
7 files changed, 617 insertions(+), 13 deletions(-)
create mode 100644 include/linux/seq_buf.h
create mode 100644 lib/seq_buf.c
--
1.8.3.4
next reply other threads:[~2015-05-19 9:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 9:08 Wang Long [this message]
2015-05-19 9:08 ` [PATCH v2 01/17] tracing: Create seq_buf layer in trace_seq Wang Long
2015-05-19 9:08 ` [PATCH v2 02/17] tracing: Convert seq_buf_path() to be like seq_path() Wang Long
2015-05-19 9:08 ` [PATCH v2 03/17] tracing: Convert seq_buf fields to be like seq_file fields Wang Long
2015-05-19 9:08 ` [PATCH v2 04/17] tracing: Add a seq_buf_clear() helper and clear len and readpos in init Wang Long
2015-05-19 9:08 ` [PATCH v2 05/17] seq_buf: Create seq_buf_used() to find out how much was written Wang Long
2015-05-19 9:08 ` [PATCH v2 06/17] tracing: Use trace_seq_used() and seq_buf_used() instead of len Wang Long
2015-05-19 9:08 ` [PATCH v2 07/17] seq_buf: Add seq_buf_can_fit() helper function Wang Long
2015-05-19 9:08 ` [PATCH v2 08/17] tracing: Have seq_buf use full buffer Wang Long
2015-05-19 9:08 ` [PATCH v2 09/17] tracing: Add seq_buf_get_buf() and seq_buf_commit() helper functions Wang Long
2015-05-19 9:08 ` [PATCH v2 10/17] seq-buf: Make seq_buf_bprintf() conditional on CONFIG_BINARY_PRINTF Wang Long
2015-05-19 9:08 ` [PATCH v2 11/17] seq_buf: Move the seq_buf code to lib/ Wang Long
2015-05-19 9:08 ` [PATCH v2 12/17] seq_buf: Fix seq_buf_vprintf() truncation Wang Long
2015-05-19 9:08 ` [PATCH v2 13/17] seq_buf: Fix seq_buf_bprintf() truncation Wang Long
2015-05-19 9:08 ` [PATCH v2 14/17] printk: Add per_cpu printk func to allow printk to be diverted Wang Long
2015-05-19 9:09 ` [PATCH v2 15/17] printk/percpu: Define printk_func when printk is not defined Wang Long
2015-05-19 9:09 ` [PATCH v2 16/17] x86/nmi: Perform a safe NMI stack trace on all CPUs Wang Long
2015-05-19 9:09 ` [PATCH v2 17/17] x86/nmi: Fix use of unallocated cpumask_var_t Wang Long
2015-05-19 12:57 ` [PATCH v2 00/17] [request for stable 3.10 inclusion] x86/nmi: Print all cpu stacks from NMI safely Petr Mladek
2015-05-20 13:22 ` Petr Mladek
2015-05-21 1:38 ` long.wanglong
2015-06-29 23:56 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432026542-123571-1-git-send-email-long.wanglong@huawei.com \
--to=long.wanglong@huawei.com \
--cc=dzickus@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=morgan.wang@huawei.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peifeiyue@huawei.com \
--cc=pmladek@suse.cz \
--cc=rostedt@goodmis.org \
--cc=sasha.levin@oracle.com \
--cc=stable@vger.kernel.org \
--cc=wanglong@laoqinren.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®