From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: [PATCH 3/4] perf tools: Get rid of dso__data_fd() from dso__data_size()
Date: Wed, 20 May 2015 15:34:06 +0900 [thread overview]
Message-ID: <1432103647-14017-3-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1432103647-14017-1-git-send-email-namhyung@kernel.org>
It seems that the dso__data_fd() was needed to find a binary type
since open in data_file_size() alone used to fail. But as it can open
the dso fine now, the dso__data_fd() can go away.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/dso.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index a3984beca723..21fae6908717 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -744,12 +744,6 @@ static int data_file_size(struct dso *dso, struct machine *machine)
*/
off_t dso__data_size(struct dso *dso, struct machine *machine)
{
- int fd;
-
- fd = dso__data_fd(dso, machine);
- if (fd < 0)
- return fd;
-
if (data_file_size(dso, machine))
return -1;
--
2.4.0
next prev parent reply other threads:[~2015-05-20 6:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 6:34 [PATCH 1/4] Revert "perf tools: Fix data_read_offset() file opening" Namhyung Kim
2015-05-20 6:34 ` [PATCH 2/4] perf tools: Fix dso__data_read_offset() file opening Namhyung Kim
2015-05-20 8:12 ` Adrian Hunter
2015-05-20 15:11 ` Namhyung Kim
2015-05-20 15:35 ` Adrian Hunter
2015-05-20 6:34 ` Namhyung Kim [this message]
2015-05-20 6:34 ` [PATCH 4/4] perf tools: Add dso__data_get/put_fd() Namhyung Kim
2015-05-20 8:33 ` Adrian Hunter
2015-05-20 15:34 ` Namhyung Kim
2015-05-20 15:55 ` Adrian Hunter
2015-05-20 13:28 ` [PATCH 1/4] Revert "perf tools: Fix data_read_offset() file opening" Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432103647-14017-3-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®