mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Abelardo Ricart III <aricart@memnix.com>, Michal Marek <mmarek@suse.cz>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
	sedat.dilek@gmail.com, dhowells@redhat.com,
	keyrings@linux-nfs.org, rusty@rustcorp.com.au,
	linux-security-module@vger.kernel.org, james.l.morris@oracle.com,
	gregkh@linuxfoundation.org
Subject: Re: [PATCH] MODSIGN: Change default key details [ver #2]
Date: Wed, 20 May 2015 11:17:01 +0100	[thread overview]
Message-ID: <1432117021.22716.21.camel@infradead.org> (raw)
In-Reply-To: <1430516505-4812-1-git-send-email-aricart@memnix.com>

[-- Attachment #1: Type: text/plain, Size: 3217 bytes --]

On Fri, 2015-05-01 at 17:41 -0400, Abelardo Ricart III wrote:
> 
> From module-signing.txt:
> 
> > Under normal conditions, the kernel build will automatically generate a new
> > keypair using openssl if one does not exist in the files:
> >
> >        signing_key.priv
> >        signing_key.x509
> 
> Nope, sorry, not true. Even if your keys exist, due to unfortunate 
> parallel make/disk write order/racy kbuild/goblins your x509.genkey 
> file has a newer timestamp than your keys, and now your keys are 
> going to get tossed (regenerated and overwritten, yay!). Worse still, 
> I think they could even get tossed AFTER the build decides "hey nice 
> keys, I'll just use those". Either way, this patch is ultimately 
> correct because this is exactly the kind of racy scenario order-only 
> prerequisites was made for. We should not care anything about 
> x509.genkey if our signing keys already exist. Period.
> 
> Here's my two-line patch strictly defining the build order, for your perusal.
> 
> Signed-off-by: Abelardo Ricart III <aricart@memnix.com>
> ---
> 
> diff --git a/kernel/Makefile b/kernel/Makefile
> index 1408b33..10c8df0 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -168,7 +168,8 @@ ifndef CONFIG_MODULE_SIG_HASH
>  $(error Could not determine digest type to use from kernel config)
>  endif
>  
> -signing_key.priv signing_key.x509: x509.genkey
> +signing_key.priv signing_key.x509: | x509.genkey
> +       $(warning *** X.509 module signing key pair not found in root of source tree ***)
>         @echo "###"
>         @echo "### Now generating an X.509 key pair to be used for signing modules."
>         @echo "###"

I think we still need this, or something equivalent. I'll take a closer
look at the dependencies and see if there's a better option — that bit
about keys being tossed AFTER the build is already using them does
definitely seem like a bug.

This approach might suffice as a last resort, but I don't like it much.
For an ephemeral key, we *do* want to rebuild it if you touch
x509.genkey. And signing_key.{priv,x509} *are* now purely intended to
be ephemeral — see 
https://lkml.org/lkml/2015/5/18/527 and my patches which David Howells
has now merged into his tree.

I suspect the real bug here will turn out to be caused by the fact that
signing_key.priv and signing_key.x509 are distinct Makefile targets and
we are *also* generating each as a side-effect of generating the other.
And make doesn't know about the side-effects.

Maybe we'd do better with a single rule for 'signing_key.pem' which
contains both key and cert. Which is the way it is for an external key
anyway. I'll look at implementing that.

I also wonder if the problem that Linus saw with "X.509 certificate
list changed" was a different issue, in the $(wildcard *.x509)
handling. I am increasingly convinced we should just ditch that entire
can of worms and take a single file named in a Kconfig option. I'll throw that together too and see if it makes me 
happy.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5691 bytes --]

  parent reply	other threads:[~2015-05-20 10:17 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 13:58 David Howells
2015-04-30 14:39 ` Sedat Dilek
2015-04-30 14:50 ` David Howells
2015-04-30 17:49   ` Sedat Dilek
2015-04-30 18:00     ` Linus Torvalds
2015-05-01 21:41       ` Abelardo Ricart III
2015-05-02  4:12         ` Linus Torvalds
2015-05-02  6:57           ` Sedat Dilek
2015-05-02  9:46           ` Abelardo Ricart III
2015-05-04  1:45             ` Linus Torvalds
2015-05-04  4:42               ` Abelardo Ricart III
     [not found]                 ` <CA+55aFzYUsXHC=_RiQFBhMmDxrFT4bqNP5F0LGWUu7Hc9sXBFQ@mail.gmail.com>
2015-05-04  7:18                   ` Abelardo Ricart III
2015-05-04 21:40                   ` Abelardo Ricart III
2015-05-05 14:34                   ` David Howells
2015-05-05 22:44                     ` Abelardo Ricart III
2015-05-04 18:45               ` Linus Torvalds
2015-05-05 15:22                 ` Michal Marek
2015-05-05 15:41                   ` Linus Torvalds
2015-05-06 12:20                     ` Michal Marek
2015-05-07 11:00                     ` David Howells
2015-05-07 12:15                       ` Michal Marek
2015-05-07 12:24                         ` Michal Marek
2015-05-08 13:05                         ` David Howells
2015-05-12  8:51                           ` Michal Marek
2015-05-15 15:21                           ` David Howells
2015-05-19 14:14                           ` David Howells
2015-05-19 15:19                             ` David Woodhouse
2015-05-18 16:07                         ` David Woodhouse
2015-05-16 15:39                 ` David Woodhouse
2015-05-18 10:47                 ` David Howells
2015-05-18 11:13                   ` David Woodhouse
2015-05-19  2:14                     ` Mimi Zohar
2015-05-18 10:56                 ` David Howells
2015-05-05 14:33               ` David Howells
2015-05-05 14:43                 ` Linus Torvalds
2015-05-05 15:30                 ` David Howells
2015-05-05 14:37               ` David Howells
2015-05-20 10:17         ` David Woodhouse [this message]
2015-05-20 11:26           ` [PATCH] modsign: Use single PEM file for autogenerated key David Woodhouse
2015-05-20 14:56           ` David Howells
2015-05-20 15:18             ` David Woodhouse
2015-05-21 11:31             ` David Woodhouse
2015-05-20 10:51         ` [PATCH] MODSIGN: Change default key details [ver #2] David Howells
2015-05-20 11:08           ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432117021.22716.21.camel@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=aricart@memnix.com \
    --cc=dhowells@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=james.l.morris@oracle.com \
    --cc=keyrings@linux-nfs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=rusty@rustcorp.com.au \
    --cc=sedat.dilek@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®