From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755100AbbEUHnl (ORCPT ); Thu, 21 May 2015 03:43:41 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50869 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755025AbbEUHnj (ORCPT ); Thu, 21 May 2015 03:43:39 -0400 From: Hannes Reinecke To: "H. Peter Anvin" Cc: linux-kernel@vger.kernel.org, Johannes Thumshirn , Hannes Reinecke , Paul Bolle Subject: [PATCHv3] edd: support original Phoenix EDD 3.0 information Date: Thu, 21 May 2015 09:43:37 +0200 Message-Id: <1432194217-72263-1-git-send-email-hare@suse.de> X-Mailer: git-send-email 1.8.5.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The original Phoenix EDD 3.0 specification (as found in eg http://mbldr.sourceforge.net/specsedd30.pdf) has a device path length of 36, not 44. All the other fields are identical, so we can trivially support both formats. Cc: Paul Bolle Signed-off-by: Hannes Reinecke --- drivers/firmware/edd.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c index e229576..0816ae5 100644 --- a/drivers/firmware/edd.c +++ b/drivers/firmware/edd.c @@ -8,6 +8,8 @@ * BIOS Enhanced Disk Drive Services (EDD) * conformant to T13 Committee www.t13.org * projects 1572D, 1484D, 1386D, 1226DT + * and the original Phoenix BIOS EDD 3.0 spec from + * * * This code takes information provided by BIOS EDD calls * fn41 - Check Extensions Present and @@ -545,8 +547,9 @@ edd_has_edd30(struct edd_device *edev) } - /* We support only T13 spec */ - if (info->params.device_path_info_length != 44) + /* We support T13 d1572 and the original Phoenix spec */ + if (info->params.device_path_info_length != 44 && + info->params.device_path_info_length != 36) return 0; for (i = 30; i < info->params.device_path_info_length + 30; i++) -- 1.8.5.2