From: Joe Perches <joe@perches.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] Docs: SubmittingPatches: Clarify convention for git commit references
Date: Thu, 21 May 2015 09:19:22 -0700 [thread overview]
Message-ID: <1432225162.20840.49.camel@perches.com> (raw)
In-Reply-To: <20150521155954.9522.33952.stgit@bhelgaas-glaptop2.roam.corp.google.com>
On Thu, 2015-05-21 at 10:59 -0500, Bjorn Helgaas wrote:
> Clarify the convention for commit references in changelogs so it matches
> what checkpatch suggests; see d311cd44545f ("checkpatch: add test for
> commit id formatting style in commit log").
>
> I chose a different example to make the ("") around the description more
> obvious.
[]
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
[]
> @@ -168,27 +168,18 @@ resources. In addition to giving a URL to a mailing list archive or
[]
> +When referring to a specific commit, please include both the first 12
maybe
When referring to a specific commit, please include both 12 or more
or "at least 12" or " a minimum of 12".
> +characters of the SHA-1 ID and the one-line summary to make it easier for
> +reviewers to know what it is about. For example:
> +
> + Commit 523c5b89640e ("i2c: Remove support for legacy PM") removed
> + the PM ops from the bus type ...
> +
> +If your patch fixes a bug in a specific commit, e.g., you found an issue
> +using git-bisect, please use the 'Fixes:' tag, again with the first 12
here too
> +characters of the SHA-1 ID and the one-line summary. For example:
> +
> + Fixes: 523c5b89640e ("i2c: Remove support for legacy PM")
>
> The following git-config settings can be used to add a pretty format for
> outputting the above style in the git log or git show commands
>
next prev parent reply other threads:[~2015-05-21 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 15:59 Bjorn Helgaas
2015-05-21 16:19 ` Joe Perches [this message]
2015-05-21 16:44 ` Bjorn Helgaas
2015-05-21 17:04 ` Joe Perches
2015-05-21 19:03 ` Josh Stone
2015-05-22 15:36 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432225162.20840.49.camel@perches.com \
--to=joe@perches.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome