From: Laurent Navet <laurent.navet@gmail.com>
To: selvin.xavier@emulex.com, devesh.sharma@emulex.com,
mitesh.ahuja@emulex.com, dledford@redhat.com,
sean.hefty@intel.com, hal.rosenstock@gmail.com
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Laurent Navet <laurent.navet@gmail.com>
Subject: [PATCH] RDMA/ocrdma: remove unneeded tests
Date: Thu, 21 May 2015 22:07:04 +0200 [thread overview]
Message-ID: <1432238824-16953-1-git-send-email-laurent.navet@gmail.com> (raw)
The same code is executed regardless status value, so these tests can
be removed.
Fix Coverity CID 1271151 and 1268788
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
index 0c9e959..e748090 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
@@ -1960,9 +1960,6 @@ static int ocrdma_mbx_reg_mr_cont(struct ocrdma_dev *dev,
upper_32_bits(hwmr->pbl_table[i + pbl_offset].pa);
}
status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
- if (status)
- goto mbx_err;
-mbx_err:
kfree(cmd);
return status;
}
@@ -3044,9 +3041,6 @@ static int ocrdma_mbx_modify_eqd(struct ocrdma_dev *dev, struct ocrdma_eq *eq,
(eq[i].aic_obj.prev_eqd * 65)/100;
}
status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
- if (status)
- goto mbx_err;
-mbx_err:
kfree(cmd);
return status;
}
--
2.1.4
next reply other threads:[~2015-05-21 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 20:07 Laurent Navet [this message]
2015-05-26 12:45 ` Doug Ledford
2015-05-26 16:00 ` Devesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432238824-16953-1-git-send-email-laurent.navet@gmail.com \
--to=laurent.navet@gmail.com \
--cc=devesh.sharma@emulex.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mitesh.ahuja@emulex.com \
--cc=sean.hefty@intel.com \
--cc=selvin.xavier@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®