mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Parav Pandit <parav.pandit@avagotech.com>
To: linux-nvme@lists.infradead.org, willy@linux.intel.com
Cc: parav.pandit@avagotech.com, axboe@kernel.dk,
	linux-kernel@vger.kernel.org
Subject: [PATCH] NVMe: Avoid interrupt disable during queue init.
Date: Thu, 21 May 2015 20:12:33 -0400	[thread overview]
Message-ID: <1432253553-17045-1-git-send-email-parav.pandit@avagotech.com> (raw)

Avoid diabling interrupt and holding q_lock for the queue
which is just getting initialized.

With this change, online_queues is also incremented without
lock during queue setup stage.
if Power management nvme_suspend() kicks in during queue setup time,
per nvmeq based q_lock spinlock cannot protect device wide
online_queues variable anyway.

Signed-off-by: Parav Pandit <parav.pandit@avagotech.com>
---
 drivers/block/nvme-core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index 58041c7..7f09e5e 100644
--- a/drivers/block/nvme-core.c
+++ b/drivers/block/nvme-core.c
@@ -1437,14 +1437,12 @@ static void nvme_init_queue(struct nvme_queue *nvmeq, u16 qid)
 {
 	struct nvme_dev *dev = nvmeq->dev;
 
-	spin_lock_irq(&nvmeq->q_lock);
 	nvmeq->sq_tail = 0;
 	nvmeq->cq_head = 0;
 	nvmeq->cq_phase = 1;
 	nvmeq->q_db = &dev->dbs[qid * 2 * dev->db_stride];
 	memset((void *)nvmeq->cqes, 0, CQ_SIZE(nvmeq->q_depth));
 	dev->online_queues++;
-	spin_unlock_irq(&nvmeq->q_lock);
 }
 
 static int nvme_create_queue(struct nvme_queue *nvmeq, int qid)
-- 
1.8.3.1


             reply	other threads:[~2015-05-21 18:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22  0:12 Parav Pandit [this message]
2015-05-21 18:39 ` Jens Axboe
2015-05-21 19:14   ` Parav Pandit
2015-05-21 19:34 ` Keith Busch
2015-05-22  4:15   ` Parav Pandit
2015-05-22 14:48     ` Keith Busch
2015-05-22 14:51       ` Parav Pandit
2015-05-22 15:11         ` Keith Busch
2015-05-22 16:03           ` Parav Pandit
2015-05-22 16:23             ` Keith Busch
2015-05-22 16:48               ` Parav Pandit
2015-05-22 17:07                 ` Keith Busch
2015-05-22 17:33                   ` Parav Pandit
2015-05-22 17:47                     ` Keith Busch
2015-05-22 18:18                       ` Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432253553-17045-1-git-send-email-parav.pandit@avagotech.com \
    --to=parav.pandit@avagotech.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®