From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751371AbbEYFUG (ORCPT ); Mon, 25 May 2015 01:20:06 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:27187 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbbEYFUC (ORCPT ); Mon, 25 May 2015 01:20:02 -0400 X-AuditID: cbfee68d-f79106d00000728c-57-5562b1002434 From: Vishnu Pratap Singh To: paul.gortmaker@windriver.com, snitzer@redhat.com, dehrenberg@chromium.org, pavel@ucw.cz, akpm@linux-foundation.org, mszeredi@suse.cz, linux-kernel@vger.kernel.org Cc: cpgs@samsung.com, Vishnu Pratap Singh Subject: [PATCH] init/do_mounts: Add create_dev() failure log Date: Mon, 25 May 2015 10:47:50 +0530 Message-id: <1432531070-4262-1-git-send-email-vishnu.ps@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <130285@samsung.com> References: <130285@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsWyRsSkSpdhY1KowY0OXYs569ewWbw8pGlx c9liJovLu+awWVz6fZfZ4tre48wWd08dZbNo2/iV0WJK311GB06P2Q0XWTxOzPjN4vF+31U2 j74tqxg9ziw4wu6xYvV3do/Pm+Q81m/ZyhTAEcVlk5Kak1mWWqRvl8CVcWLGZZaC52wVF9bd ZmxgPMnaxcjJISFgIrGg8SA7hC0mceHeerYuRi4OIYGljBKrbyxnhyk63beEHSIxnVHi2Y5b TCAJIYEmJokNRz1AbDYBQ4kNs4+AFYkIrGKU+L3sNFg3s4CjxKxDV5hBbGEBW4mtLx4zgtgs AqoSC/unsoDYvAIuEp+eXAGyOYC2KUjMmWQDEuYUUJSY8OwOG8QuBYn/B38yQxx0iF3i0xUN iDECEt8mH4JqlZXYdACqRFLi4IobLBMYhRcwMqxiFE0tSC4oTkovMtQrTswtLs1L10vOz93E CIyK0/+e9e5gvH3A+hCjAAejEg9vREZSqBBrYllxZe4hRlOgDROZpUST84Gxl1cSb2hsZmRh amJqbGRuaaYkzqso9TNYSCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dUA+PkppLYiy2Lrjh5GT+x vDo/Pud83FmGrUczrtaruPkrTvBk9s83K3vKWZPs2HbG2TnnRpI9b+IEvvN1DxY/vlM2y3CF u/JPRfGIA/cC/jE+MXa04mQ5N/eTwP01dcledfMdZXSfFJV4tC12tDI867lm6Y/fkwxsY2Ny umu7/pRJ/YyT6a8XVGIpzkg01GIuKk4EAArL/zWFAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLIsWRmVeSWpSXmKPExsVy+t9jQV2GjUmhBttvKFjMWb+GzeLlIU2L m8sWM1lc3jWHzeLS77vMFtf2Hme2uHvqKJtF28avjBZT+u4yOnB6zG64yOJxYsZvFo/3+66y efRtWcXocWbBEXaPFau/s3t83iTnsX7LVqYAjqgGRpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4 UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoPuUFMoSc0qBQgGJxcVK+naYJoSGuOlawDRG6PqG BMH1GBmggYQ1jBknZlxmKXjOVnFh3W3GBsaTrF2MnBwSAiYSp/uWsEPYYhIX7q1n62Lk4hAS mM4o8WzHLSaQhJBAE5PEhqMeIDabgKHEhtlH2EGKRARWMUr8XnYarJtZwFFi1qErzCC2sICt xNYXjxlBbBYBVYmF/VNZQGxeAReJT0+uANkcQNsUJOZMsgEJcwooSkx4docNYpeCxP+DP5kn MPIuYGRYxSiaWpBcUJyUnmuoV5yYW1yal66XnJ+7iREcdc+kdjCubLA4xCjAwajEwxuRkRQq xJpYVlyZe4hRgoNZSYRXdANQiDclsbIqtSg/vqg0J7X4EKMp0FETmaVEk/OBCSGvJN7Q2MTc 1NjU0sTCxMxSSZz3ZL5PqJBAemJJanZqakFqEUwfEwenVANjXZ3Bh3kb/nqEm3BN+O11WFVc 7fCP1eExBU6FGWbKp+ZcCwnV/qNw5eLSeSl6+gptIXyX3X99t+k1kzg89YzRpBTZlVs2iLy6 8zDGWO6t1ukpyX/5ilzPf25YXxfn39sXUc7/nSFj6qRfW8yEPyxn05+s0pu5d4f6Zp1pSQ+W q3svyxHem1eoxFKckWioxVxUnAgATG9mAdACAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org if create_dev() function fails to create the root mount device (/dev/root), then it goes to panic as root device not found but there is no check/log present in case of failure, So i have added the log in case it fails to create the root device. It will help in debugging. Signed-off-by: Vishnu Pratap Singh --- init/do_mounts.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/init/do_mounts.c b/init/do_mounts.c index 8369ffa..a68aaf6 100644 --- a/init/do_mounts.c +++ b/init/do_mounts.c @@ -532,7 +532,8 @@ void __init mount_root(void) } #endif #ifdef CONFIG_BLOCK - create_dev("/dev/root", ROOT_DEV); + if(create_dev("/dev/root", ROOT_DEV) < 0) + printk(KERN_ERR "Failed to create %s device !!\n", "/dev/root"); mount_block_root("/dev/root", root_mountflags); #endif } -- 1.7.9.5