mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Feng Wu <feng.wu@intel.com>
To: joro@8bytes.org, dwmw2@infradead.org
Cc: tglx@linutronix.de, jiang.liu@linux.intel.com,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	Feng Wu <feng.wu@intel.com>
Subject: [v7 4/8] iommu, x86: No need to migrating irq for VT-d Posted-Interrupts
Date: Mon, 25 May 2015 13:28:50 +0800	[thread overview]
Message-ID: <1432531734-25978-5-git-send-email-feng.wu@intel.com> (raw)
In-Reply-To: <1432531734-25978-1-git-send-email-feng.wu@intel.com>

We don't need to migrate the irqs for VT-d Posted-Interrupts here.
When 'pst' is set in IRTE, the associated irq will be posted to
guests instead of interrupt remapping. The destination of the
interrupt is set in Posted-Interrupts Descriptor, and the migration
happens during vCPU scheduling.

However, we still update the cached irte here, which can be used
when changing back to remapping mode.

Signed-off-by: Feng Wu <feng.wu@intel.com>
Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com>
Acked-by: David Woodhouse <David.Woodhouse@intel.com>
---
 drivers/iommu/intel_irq_remapping.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
index 1955b09..646f4cf 100644
--- a/drivers/iommu/intel_irq_remapping.c
+++ b/drivers/iommu/intel_irq_remapping.c
@@ -994,7 +994,10 @@ intel_ir_set_affinity(struct irq_data *data, const struct cpumask *mask,
 	 */
 	irte->vector = cfg->vector;
 	irte->dest_id = IRTE_DEST(cfg->dest_apicid);
-	modify_irte(&ir_data->irq_2_iommu, irte);
+
+	/* We don't need to modify irte if the interrupt is for posting. */
+	if (irte->pst != 1)
+		modify_irte(&ir_data->irq_2_iommu, irte);
 
 	/*
 	 * After this point, all the interrupts will start arriving
-- 
2.1.0


  parent reply	other threads:[~2015-05-25  5:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-25  5:28 [v7 0/8] Add VT-d Posted-Interrupts support - IOMMU part Feng Wu
2015-05-25  5:28 ` [v7 1/8] iommu: Add new member capability to struct irq_remap_ops Feng Wu
2015-05-25  5:28 ` [v7 2/8] iommu: dmar: Extend struct irte for VT-d Posted-Interrupts Feng Wu
2015-05-25  5:28 ` [v7 3/8] iommu, x86: Implement irq_set_vcpu_affinity for intel_ir_chip Feng Wu
2015-05-25  5:28 ` Feng Wu [this message]
2015-05-25  8:38   ` [v7 4/8] iommu, x86: No need to migrating irq for VT-d Posted-Interrupts Thomas Gleixner
2015-05-26  2:53     ` Wu, Feng
2015-05-26 10:00       ` Thomas Gleixner
2015-05-26 13:59         ` Wu, Feng
2015-05-25  5:28 ` [v7 5/8] iommu, x86: Add cap_pi_support() to detect VT-d PI capability Feng Wu
2015-05-25  5:28 ` [v7 6/8] iommu, x86: Setup Posted-Interrupts capability for Intel iommu Feng Wu
2015-05-25  5:28 ` [v7 7/8] iommu, x86: define irq_remapping_cap() Feng Wu
2015-05-25  5:28 ` [v7 8/8] iommu, x86: Properly handler PI for IOMMU hotplug Feng Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432531734-25978-5-git-send-email-feng.wu@intel.com \
    --to=feng.wu@intel.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jiang.liu@linux.intel.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®