From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751461AbbEYNwK (ORCPT ); Mon, 25 May 2015 09:52:10 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:45893 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751126AbbEYNwI (ORCPT ); Mon, 25 May 2015 09:52:08 -0400 X-AuditID: cbfee68f-f793b6d000005f66-bc-556329069197 From: Vishnu Pratap Singh To: paul.gortmaker@windriver.com, snitzer@redhat.com, dehrenberg@chromium.org, pavel@ucw.cz, akpm@linux-foundation.org, mszeredi@suse.cz, linux-kernel@vger.kernel.org Cc: cpgs@samsung.com, Vishnu Pratap Singh Subject: [PATCH] init/do_mounts: Add create_dev() failure log Date: Mon, 25 May 2015 19:19:43 +0530 Message-id: <1432561783-3317-1-git-send-email-vishnu.ps@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1432531070-4262-1-git-send-email-vishnu.ps@samsung.com> References: <1432531070-4262-1-git-send-email-vishnu.ps@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsWyRsSkWpdNMznUYOIsY4s569ewWbw8pGlx c9liJovLu+awWVz6fZfZ4tre48wWd08dZbNo2/iV0WJK311GB06P2Q0XWTxOzPjN4vF+31U2 j74tqxg9ziw4wu6xYvV3do/Pm+Q81m/ZyhTAEcVlk5Kak1mWWqRvl8CVcWLGZZaC52wVF9bd ZmxgPMnaxcjJISFgIvGyeRsThC0mceHeerYuRi4OIYGljBKfp+yFKzq1+TRUYhGjxOxV71lA EkICTUwS18+qgthsAoYSG2YfYQcpEhFYxSjxe9lpdpAEs4CjxKxDV5hBbGEBW4mtLx4zdjFy cLAIqEqceM8IEuYVcJGY/vAWE0hYQkBBYs4kG5Awp4CrxOoVu1khVrlIzH/ZyAoyXkLgGLvE jW+/2EASLAICEt8mH2KB6JWV2HSAGeJmSYmDK26wTGAUXsDIsIpRNLUguaA4Kb3IWK84Mbe4 NC9dLzk/dxMjMCpO/3vWv4Px7gHrQ4wCHIxKPLwRGUmhQqyJZcWVuYcYTYE2TGSWEk3OB8Ze Xkm8obGZkYWpiamxkbmlmZI470Kpn8FCAumJJanZqakFqUXxRaU5qcWHGJk4OKUaGC0VBZO6 Er6JdP2/L5k5I/Cg0rWI49mmb7lauy+Uhkkuv8im5tgbcbXHWirBbu/si12/jffOEHB4cPyc mNnjPdKOcYeeB4v7TLqisuGjGsvyid/M2O8f1Tl05XJ2dA3nuQ69pUcf33u4+vTpDQcC/P40 LP5gmeaX4HVN42Kn2+oT9+9vcsvhnqXEUpyRaKjFXFScCACg0QilhQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsVy+t9jAV02zeRQg8vLdC3mrF/DZvHykKbF zWWLmSwu75rDZnHp911mi2t7jzNb3D11lM2ibeNXRospfXcZHTg9ZjdcZPE4MeM3i8f7fVfZ PPq2rGL0OLPgCLvHitXf2T0+b5LzWL9lK1MAR1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8 qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0H1KCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1D guB6jAzQQMIaxowTMy6zFDxnq7iw7jZjA+NJ1i5GTg4JAROJU5tPs0HYYhIX7q0Hsrk4hAQW MUrMXvWeBSQhJNDEJHH9rCqIzSZgKLFh9hF2kCIRgVWMEr+XnWYHSTALOErMOnSFGcQWFrCV 2PriMWMXIwcHi4CqxIn3jCBhXgEXiekPbzGBhCUEFCTmTLIBCXMKuEqsXrGbFWKVi8T8l42s Exh5FzAyrGIUTS1ILihOSs810itOzC0uzUvXS87P3cQIjrln0jsYVzVYHGIU4GBU4uGNyEgK FWJNLCuuzD3EKMHBrCTCKyCbHCrEm5JYWZValB9fVJqTWnyI0RToponMUqLJ+cB0kFcSb2hs Ym5qbGppYmFiZqkkznsy3ydUSCA9sSQ1OzW1ILUIpo+Jg1OqgdEw65T8LZHKhk5Z56/p0lJM rvJrvPdrHti3af/6U0tW+wWp8znINNrPenjJ4676I2f1s/eOnw1eL72/rf9g0/zLytMOepeo H30fddP36opZvwrXL9W13rsp9Xnl4325dhd5ghcdkVStZORlUXs3pcPgBNN0nZ39M9Tm/+8u ufzw+Op8prQJHOZKLMUZiYZazEXFiQCZ/DEtzwIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org if create_dev() function fails to create the root mount device (/dev/root), then it goes to panic as root device not found but there is no check/log present in case of failure, So i have added the log in case it fails to create the root device. It will help in debugging. Signed-off-by: Vishnu Pratap Singh --- init/do_mounts.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/init/do_mounts.c b/init/do_mounts.c index 8369ffa..a68aaf6 100644 --- a/init/do_mounts.c +++ b/init/do_mounts.c @@ -532,7 +532,8 @@ void __init mount_root(void) } #endif #ifdef CONFIG_BLOCK - create_dev("/dev/root", ROOT_DEV); + if(create_dev("/dev/root", ROOT_DEV) < 0) + printk(KERN_ERR "Failed to create %s device !!\n", "/dev/root"); mount_block_root("/dev/root", root_mountflags); #endif } -- 1.7.9.5