From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751992AbbEZHAr (ORCPT ); Tue, 26 May 2015 03:00:47 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:51501 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbbEZHAl (ORCPT ); Tue, 26 May 2015 03:00:41 -0400 X-AuditID: cbfee68f-f793b6d000005f66-fe-55641297bcec From: Vishnu Pratap Singh To: paul.gortmaker@windriver.com, snitzer@redhat.com, dehrenberg@chromium.org, pavel@ucw.cz, akpm@linux-foundation.org, mszeredi@suse.cz, linux-kernel@vger.kernel.org Cc: cpgs@samsung.com, Vishnu Pratap Singh Subject: [PATCHv2] init/do_mounts: Add create_dev() failure log Date: Tue, 26 May 2015 11:56:58 +0530 Message-id: <1432621618-9567-1-git-send-email-vishnu.ps@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1432531070-4262-1-git-send-email-vishnu.ps@samsung.com> References: <1432531070-4262-1-git-send-email-vishnu.ps@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsWyRsSkRne6UEqowe4jahZz1q9hs3h5SNPi 5rLFTBaXd81hs7j0+y6zxbW9x5kt7p46ymbRtvEro8WUvruMDpwesxsusnicmPGbxeP9vqts Hn1bVjF6nFlwhN1jxerv7B6fN8l5rN+ylSmAI4rLJiU1J7MstUjfLoEr4/c1zoI/bBXPv65j b2C8xtrFyMkhIWAiMXP/LGYIW0ziwr31bF2MXBxCAksZJSa3LgZyOMCKLpyzgIgvYpTYtHo5 M4TTxCTxb+93JpBuNgFDiQ2zj7CDJEQEVjFK/F52mh0kwSzgKDHr0BWwFcIC9hKz/vwEW80i oCrxYe4ORhCbV8BFouP6XmaIbQoScybZgIQ5BVwlVq/YDVYuBFQy/2UjK8h8CYF97BLzF89m h5gjIPFt8iEWiF5ZiU0HoL6RlDi44gbLBEbhBYwMqxhFUwuSC4qT0ouM9YoTc4tL89L1kvNz NzECo+L0v2f9OxjvHrA+xCjAwajEw2txODlUiDWxrLgy9xCjKdCGicxSosn5wNjLK4k3NDYz sjA1MTU2Mrc0UxLnXSj1M1hIID2xJDU7NbUgtSi+qDQntfgQIxMHp1QD40YP21W7ojnmTdKy WOB7f/kbucuNETmzJN1T9q1aNFMk9nNUUDJ3z7b/+kyVnrKbGOWUpk2y0HW6mTJ7suexq98a by9f8btToIMhJtUo/r9p9DMO95nZScuY3jAlip69rHEximvbzXbpL2urcp9x1vPsS9aO+l24 3lNsjv3mGI4fT0Uvff55QYmlOCPRUIu5qDgRAMNUsLmFAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsVy+t9jAd3pQimhBtPnyVnMWb+GzeLlIU2L m8sWM1lc3jWHzeLS77vMFtf2Hme2uHvqKJtF28avjBZT+u4yOnB6zG64yOJxYsZvFo/3+66y efRtWcXocWbBEXaPFau/s3t83iTnsX7LVqYAjqgGRpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4 UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoPuUFMoSc0qBQgGJxcVK+naYJoSGuOlawDRG6PqG BMH1GBmggYQ1jBm/r3EW/GGreP51HXsD4zXWLkYODgkBE4kL5yy6GDmBTDGJC/fWs3UxcnEI CSxilNi0ejkzhNPEJPFv73cmkCo2AUOJDbOPsIMkRARWMUr8XnaaHSTBLOAoMevQFWYQW1jA XmLWn5+sIDaLgKrEh7k7GEFsXgEXiY7re5khNitIzJlkAxLmFHCVWL1iN1i5EFDJ/JeNrBMY eRcwMqxiFE0tSC4oTkrPNdQrTswtLs1L10vOz93ECI65Z1I7GFc2WBxiFOBgVOLhtTicHCrE mlhWXJl7iFGCg1lJhDfhKVCINyWxsiq1KD++qDQntfgQoynQUROZpUST84HpIK8k3tDYxNzU 2NTSxMLEzFJJnPdkvk+okEB6YklqdmpqQWoRTB8TB6dUA2Mn99NQkeDTIlM+7hD7FdWU/On9 /sLu+wL8NhUF1zdbKyivYV6RZ619zWpxOK/e27VB/iJlskXP9rlyih6xrZ63+8VnhvMbHvS6 xt1qc3nkvtlETJEnptPz64LimyqT9/oxu01xXMqjknpZj9372ul1GZ6Sx35Ol/6fnBors3x1 dfevuDvePEosxRmJhlrMRcWJADeu+QnPAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org if create_dev() function fails to create the root mount device (/dev/root), then it goes to panic as root device not found but there is no check/log present in case of failure, So i have added the log in case it fails to create the root device. It will help in debugging. Signed-off-by: Vishnu Pratap Singh --- As per the review comment. init/do_mounts.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/init/do_mounts.c b/init/do_mounts.c index 8369ffa..f742250 100644 --- a/init/do_mounts.c +++ b/init/do_mounts.c @@ -532,7 +532,8 @@ void __init mount_root(void) } #endif #ifdef CONFIG_BLOCK - create_dev("/dev/root", ROOT_DEV); + if (create_dev("/dev/root", ROOT_DEV) < 0) + pr_err("Failed to create %s device !\n", "/dev/root"); mount_block_root("/dev/root", root_mountflags); #endif } -- 1.7.9.5