mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Adrian Hunter <adrian.hunter@intel.com>,
	Jiri Olsa <jolsa@redhat.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 34/37] perf tools: Output sample flags and insn_len from intel_bts
Date: Tue, 26 May 2015 13:48:05 -0300	[thread overview]
Message-ID: <1432658888-7993-35-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1432658888-7993-1-git-send-email-acme@kernel.org>

From: Adrian Hunter <adrian.hunter@intel.com>

intel_bts synthesizes samples.  Fill in the new flags and insn_len
members with instruction information.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1432295653-13989-13-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/intel-bts.c | 126 ++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 122 insertions(+), 4 deletions(-)

diff --git a/tools/perf/util/intel-bts.c b/tools/perf/util/intel-bts.c
index 48bcbd607ef7..b068860d4940 100644
--- a/tools/perf/util/intel-bts.c
+++ b/tools/perf/util/intel-bts.c
@@ -30,6 +30,7 @@
 #include "debug.h"
 #include "tsc.h"
 #include "auxtrace.h"
+#include "intel-pt-decoder/intel-pt-insn-decoder.h"
 #include "intel-bts.h"
 
 #define MAX_TIMESTAMP (~0ULL)
@@ -58,6 +59,7 @@ struct intel_bts {
 	bool				cap_user_time_zero;
 	struct itrace_synth_opts	synth_opts;
 	bool				sample_branches;
+	u32				branches_filter;
 	u64				branches_sample_type;
 	u64				branches_id;
 	size_t				branches_event_size;
@@ -74,6 +76,8 @@ struct intel_bts_queue {
 	pid_t			tid;
 	int			cpu;
 	u64			time;
+	struct intel_pt_insn	intel_pt_insn;
+	u32			sample_flags;
 };
 
 struct branch {
@@ -281,6 +285,8 @@ static int intel_bts_synth_branch_sample(struct intel_bts_queue *btsq,
 	sample.stream_id = btsq->bts->branches_id;
 	sample.period = 1;
 	sample.cpu = btsq->cpu;
+	sample.flags = btsq->sample_flags;
+	sample.insn_len = btsq->intel_pt_insn.length;
 
 	if (bts->synth_opts.inject) {
 		event.sample.header.size = bts->branches_event_size;
@@ -300,11 +306,115 @@ static int intel_bts_synth_branch_sample(struct intel_bts_queue *btsq,
 	return ret;
 }
 
+static int intel_bts_get_next_insn(struct intel_bts_queue *btsq, u64 ip)
+{
+	struct machine *machine = btsq->bts->machine;
+	struct thread *thread;
+	struct addr_location al;
+	unsigned char buf[1024];
+	size_t bufsz;
+	ssize_t len;
+	int x86_64;
+	uint8_t cpumode;
+
+	bufsz = intel_pt_insn_max_size();
+
+	if (machine__kernel_ip(machine, ip))
+		cpumode = PERF_RECORD_MISC_KERNEL;
+	else
+		cpumode = PERF_RECORD_MISC_USER;
+
+	thread = machine__find_thread(machine, -1, btsq->tid);
+	if (!thread)
+		return -1;
+
+	thread__find_addr_map(thread, cpumode, MAP__FUNCTION, ip, &al);
+	if (!al.map || !al.map->dso)
+		return -1;
+
+	len = dso__data_read_addr(al.map->dso, al.map, machine, ip, buf, bufsz);
+	if (len <= 0)
+		return -1;
+
+	/* Load maps to ensure dso->is_64_bit has been updated */
+	map__load(al.map, machine->symbol_filter);
+
+	x86_64 = al.map->dso->is_64_bit;
+
+	if (intel_pt_get_insn(buf, len, x86_64, &btsq->intel_pt_insn))
+		return -1;
+
+	return 0;
+}
+
+static int intel_bts_synth_error(struct intel_bts *bts, int cpu, pid_t pid,
+				 pid_t tid, u64 ip)
+{
+	union perf_event event;
+	int err;
+
+	auxtrace_synth_error(&event.auxtrace_error, PERF_AUXTRACE_ERROR_ITRACE,
+			     INTEL_BTS_ERR_NOINSN, cpu, pid, tid, ip,
+			     "Failed to get instruction");
+
+	err = perf_session__deliver_synth_event(bts->session, &event, NULL);
+	if (err)
+		pr_err("Intel BTS: failed to deliver error event, error %d\n",
+		       err);
+
+	return err;
+}
+
+static int intel_bts_get_branch_type(struct intel_bts_queue *btsq,
+				     struct branch *branch)
+{
+	int err;
+
+	if (!branch->from) {
+		if (branch->to)
+			btsq->sample_flags = PERF_IP_FLAG_BRANCH |
+					     PERF_IP_FLAG_TRACE_BEGIN;
+		else
+			btsq->sample_flags = 0;
+		btsq->intel_pt_insn.length = 0;
+	} else if (!branch->to) {
+		btsq->sample_flags = PERF_IP_FLAG_BRANCH |
+				     PERF_IP_FLAG_TRACE_END;
+		btsq->intel_pt_insn.length = 0;
+	} else {
+		err = intel_bts_get_next_insn(btsq, branch->from);
+		if (err) {
+			btsq->sample_flags = 0;
+			btsq->intel_pt_insn.length = 0;
+			if (!btsq->bts->synth_opts.errors)
+				return 0;
+			err = intel_bts_synth_error(btsq->bts, btsq->cpu,
+						    btsq->pid, btsq->tid,
+						    branch->from);
+			return err;
+		}
+		btsq->sample_flags = intel_pt_insn_type(btsq->intel_pt_insn.op);
+		/* Check for an async branch into the kernel */
+		if (!machine__kernel_ip(btsq->bts->machine, branch->from) &&
+		    machine__kernel_ip(btsq->bts->machine, branch->to) &&
+		    btsq->sample_flags != (PERF_IP_FLAG_BRANCH |
+					   PERF_IP_FLAG_CALL |
+					   PERF_IP_FLAG_SYSCALLRET))
+			btsq->sample_flags = PERF_IP_FLAG_BRANCH |
+					     PERF_IP_FLAG_CALL |
+					     PERF_IP_FLAG_ASYNC |
+					     PERF_IP_FLAG_INTERRUPT;
+	}
+
+	return 0;
+}
+
 static int intel_bts_process_buffer(struct intel_bts_queue *btsq,
 				    struct auxtrace_buffer *buffer)
 {
 	struct branch *branch;
-	size_t sz;
+	size_t sz, bsz = sizeof(struct branch);
+	u32 filter = btsq->bts->branches_filter;
 	int err = 0;
 
 	if (buffer->use_data) {
@@ -318,14 +428,15 @@ static int intel_bts_process_buffer(struct intel_bts_queue *btsq,
 	if (!btsq->bts->sample_branches)
 		return 0;
 
-	while (sz > sizeof(struct branch)) {
+	for (; sz > bsz; branch += 1, sz -= bsz) {
 		if (!branch->from && !branch->to)
 			continue;
+		intel_bts_get_branch_type(btsq, branch);
+		if (filter && !(filter & btsq->sample_flags))
+			continue;
 		err = intel_bts_synth_branch_sample(btsq, branch);
 		if (err)
 			break;
-		branch += 1;
-		sz -= sizeof(struct branch);
 	}
 	return err;
 }
@@ -771,6 +882,13 @@ int intel_bts_process_auxtrace_info(union perf_event *event,
 	else
 		itrace_synth_opts__set_default(&bts->synth_opts);
 
+	if (bts->synth_opts.calls)
+		bts->branches_filter |= PERF_IP_FLAG_CALL | PERF_IP_FLAG_ASYNC |
+					PERF_IP_FLAG_TRACE_END;
+	if (bts->synth_opts.returns)
+		bts->branches_filter |= PERF_IP_FLAG_RETURN |
+					PERF_IP_FLAG_TRACE_BEGIN;
+
 	err = intel_bts_synth_events(bts, session);
 	if (err)
 		goto err_free_queues;
-- 
2.1.0


  parent reply	other threads:[~2015-05-26 16:51 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-26 16:47 [GIT PULL 00/37] perf/core improvements and fixes Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 01/37] perf tools: Separate the tests and tools in installation Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 02/37] perf tools: Fix function declarations needed by parse-events.y Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 03/37] perf tools: Fix parse_events_error dereferences Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 04/37] perf build: Fix libunwind feature detection on 32-bit x86 Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 05/37] perf session: Fix perf_session__peek_event() Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 06/37] perf hists: Reducing arguments of hist_entry_iter__add() Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 07/37] perf hists: Rename add_hist_entry to hists__findnew_entry Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 08/37] perf comm: Use atomic.h for refcounting Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 09/37] perf machine: Do not call map_groups__delete(), drop refcnt instead Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 10/37] perf tools: Fix dso__data_read_offset() file opening Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 11/37] perf tools: Get rid of dso__data_fd() from dso__data_size() Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 12/37] perf tools: Add dso__data_get/put_fd() Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 13/37] perf tools: Rename maps__next Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 14/37] perf tools: Remove redundant initialization of thread linkage members Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 15/37] perf tools: Nuke unused map_groups__flush() Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 16/37] perf tools: Import rb_erase_init from block/ in the kernel sources Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 17/37] perf machine: Mark removed threads as such Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 18/37] perf tools: Leave DSO destruction to the map destruction Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 19/37] perf tools: Use maps__first()/map__next() Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 20/37] perf tools: Assign default value for some pointers Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 21/37] perf tools: Improve setting of gcc debug option Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 22/37] perf sched: Add option to merge like comms to lat output Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 23/37] perf tools: Disallow PMU events intel_pt and intel_bts until there is support Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 24/37] perf auxtrace: Add Intel PT as an AUX area tracing type Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 25/37] perf tools: Add Intel PT packet decoder Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 26/37] perf tools: Add Intel PT instruction decoder Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 27/37] perf tools: Add Intel PT log Arnaldo Carvalho de Melo
2015-05-26 16:47 ` [PATCH 28/37] perf tools: Add Intel PT decoder Arnaldo Carvalho de Melo
2015-05-26 16:48 ` [PATCH 29/37] perf tools: Add Intel PT support Arnaldo Carvalho de Melo
2015-05-26 16:48 ` [PATCH 30/37] perf tools: Take Intel PT into use Arnaldo Carvalho de Melo
2015-05-26 16:48 ` [PATCH 31/37] perf tools: Allow auxtrace data alignment Arnaldo Carvalho de Melo
2015-05-26 16:48 ` [PATCH 32/37] perf tools: Add Intel BTS support Arnaldo Carvalho de Melo
2015-05-26 16:48 ` [PATCH 33/37] perf tools: Output sample flags and insn_len from intel_pt Arnaldo Carvalho de Melo
2015-05-26 16:48 ` Arnaldo Carvalho de Melo [this message]
2015-05-26 16:48 ` [PATCH 35/37] perf tools: Intel PT to always update thread stack trace number Arnaldo Carvalho de Melo
2015-05-26 16:48 ` [PATCH 36/37] perf tools: Intel BTS " Arnaldo Carvalho de Melo
2015-05-26 16:48 ` [PATCH 37/37] perf tools: Put itrace options into an asciidoc include Arnaldo Carvalho de Melo
2015-05-27  7:38 ` [GIT PULL 00/37] perf/core improvements and fixes Ingo Molnar
2015-05-27 12:35   ` Arnaldo Carvalho de Melo
2015-05-27 12:40     ` Adrian Hunter
2015-05-27 12:45     ` Ingo Molnar
2015-06-05 13:21     ` Adrian Hunter
2015-06-05 14:08       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432658888-7993-35-git-send-email-acme@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome