From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752061AbbE0BKL (ORCPT ); Tue, 26 May 2015 21:10:11 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:33775 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbbE0BKI (ORCPT ); Tue, 26 May 2015 21:10:08 -0400 From: Shailendra Verma To: Andy Whitcroft , Joe Perches Cc: linux-kernel@vger.kernel.org, Shailendra Verma Subject: [PATCH] scripts:checkpatch - Do not give error if static bool or global bool variables are assigned to false value. Date: Wed, 27 May 2015 06:39:55 +0530 Message-Id: <1432688995-2931-1-git-send-email-shailendra.capricorn@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The bool value false is not always to be 0.So this patch will prevent for error if static bool or global bool are initialized with false value. Signed-off-by: Shailendra Verma --- scripts/checkpatch.pl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 89b1df4..74901c6 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3169,21 +3169,21 @@ sub process { } # check for global initialisers. - if ($line =~ /^\+(\s*$Type\s*$Ident\s*(?:\s+$Modifier))*\s*=\s*(0|NULL|false)\s*;/) { + if ($line =~ /^\+(\s*$Type\s*$Ident\s*(?:\s+$Modifier))*\s*=\s*(0|NULL)\s*;/) { if (ERROR("GLOBAL_INITIALISERS", "do not initialise globals to 0 or NULL\n" . $herecurr) && $fix) { - $fixed[$fixlinenr] =~ s/($Type\s*$Ident\s*(?:\s+$Modifier))*\s*=\s*(0|NULL|false)\s*;/$1;/; + $fixed[$fixlinenr] =~ s/($Type\s*$Ident\s*(?:\s+$Modifier))*\s*=\s*(0|NULL)\s*;/$1;/; } } # check for static initialisers. - if ($line =~ /^\+.*\bstatic\s.*=\s*(0|NULL|false)\s*;/) { + if ($line =~ /^\+.*\bstatic\s.*=\s*(0|NULL)\s*;/) { if (ERROR("INITIALISED_STATIC", "do not initialise statics to 0 or NULL\n" . $herecurr) && $fix) { - $fixed[$fixlinenr] =~ s/(\bstatic\s.*?)\s*=\s*(0|NULL|false)\s*;/$1;/; + $fixed[$fixlinenr] =~ s/(\bstatic\s.*?)\s*=\s*(0|NULL)\s*;/$1;/; } } -- 1.7.9.5