From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751877AbbE0FNI (ORCPT ); Wed, 27 May 2015 01:13:08 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:56064 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959AbbE0FNE (ORCPT ); Wed, 27 May 2015 01:13:04 -0400 Message-ID: <1432703582.26863.33.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH-v2 0/4] target: Eliminate se_port + t10_alua_tg_pt_gp_member From: "Nicholas A. Bellinger" To: Bart Van Assche Cc: "Nicholas A. Bellinger" , target-devel , linux-scsi , linux-kernel , Christoph Hellwig , Hannes Reinecke , Sagi Grimberg , "Paul E. McKenney" Date: Tue, 26 May 2015 22:13:02 -0700 In-Reply-To: <55646A9E.5050401@sandisk.com> References: <1432623445-25776-1-git-send-email-nab@daterainc.com> <55646A9E.5050401@sandisk.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-05-26 at 14:44 +0200, Bart Van Assche wrote: > On 05/26/15 08:57, Nicholas A. Bellinger wrote: > > - Add various rcu_dereference and lockless_dereference RCU notation > > Hello Nic, > > Feedback from an RCU expert (which I'm not) would be appreciated here. > But my understanding is that lockless_dereference(p) should be used for > a pointer p that has *not* been annotated as an RCU pointer. I think in > the for-next branch of the target repository that this macro is used to > access RCU-annotated pointers. Is that why sparse complains about how > lockless_dereference() is used in the target tree ? > Was curious about this myself.. Thanks for raising the question! The intention of lockless_dereference() in both this and preceding series is for __rcu protected pointers that are accessed outside of rcu_read_lock() protection, and who's lifetime is controlled by a: - struct kref - struct percpu_ref - struct config_group symlink - RCU updater path with some manner of mutex or spinlock held This is supposed to be following Paul's comment in rcupdate.h: * Similar to rcu_dereference(), but for situations where the pointed-to * object's lifetime is managed by something other than RCU. That * "something other" might be reference counting or simple immortality. Paul, would you be to kind to clarify the intention for us..? Thank you, --nab