From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753550AbbE1BsE (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 May 2015 21:48:04 -0400
Received: from smtprelay0080.hostedemail.com ([216.40.44.80]:52574 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1752626AbbE1Br4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 May 2015 21:47:56 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3872:3874:4250:4321:5007:6261:9545:10004:10400:10848:11232:11658:11914:12296:12517:12519:12740:13069:13095:13161:13229:13311:13357:13544:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: guide39_61edf6cb7d40c
X-Filterd-Recvd-Size: 1608
Message-ID: <1432777672.2846.190.camel@perches.com>
Subject: Re: [PATCH] core: Convert the function process_ipcsec to the,
 return type bool
From: Joe Perches <joe@perches.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: davem@davemloft.ne, brouer@redhat.com, edumazet@google.com,
        ast@plumgrid.com, sd@queasysnail.net, elfring@users.sourceforge.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Wed, 27 May 2015 18:47:52 -0700
In-Reply-To: <1432775694-30144-1-git-send-email-xerofoify@gmail.com>
References: <1432775694-30144-1-git-send-email-xerofoify@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.11-0ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2015-05-27 at 21:14 -0400, Nicholas Krause wrote:
> This makes the function,process_ipsec have a return true
> of bool now due to only returning 1 or 0. In additon this
> changes this function's return statements to return true
> and false rather then 1 and 0 respectfully.

The patch subject title and the grammar in the commit message
could be improved, but other than that, it seems OK to me.

I would have written something like:

Subject: [PATCH] pktgen: Convert return type of process_ipsec to bool

It's used as a bool function, make it so.
Convert the return 1/0 to return true/false too.

Signed-off-by: etc...