From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751508AbbE1EJA (ORCPT ); Thu, 28 May 2015 00:09:00 -0400 Received: from smtprelay0121.hostedemail.com ([216.40.44.121]:44675 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750886AbbE1EIu (ORCPT ); Thu, 28 May 2015 00:08:50 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:4321:4385:4605:5007:6261:7514:7875:8957:10004:10400:10848:11026:11232:11658:11914:12295:12296:12517:12519:12555:12740:13019:13069:13095:13161:13229:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: crime18_12a00160fb355 X-Filterd-Recvd-Size: 2166 Message-ID: <1432786126.2846.196.camel@perches.com> Subject: Re: [PATCHv2] pktgen: Convert return type of process_ipsec to bool From: Joe Perches To: Nicholas Krause Cc: davem@davemloft.net, brouer@redhat.com, edumazet@google.com, ast@plumgrid.com, stephen@networkplumber.org, fabf@skynet.be, sd@queasysnail.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 27 May 2015 21:08:46 -0700 In-Reply-To: <1432785621-30921-1-git-send-email-xerofoify@gmail.com> References: <1432785621-30921-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-05-28 at 00:00 -0400, Nicholas Krause wrote: > This converts the function, process_ipsec to the > return type of bool due to only returning either > one or zero. > v2 > Change incorrect patch subject and make commit message > clearer > > Signed-off-by: Nicholas Krause > --- The V2 changelog delta goes here below the --- line Not in the commit message area. TrySend a v3 > net/core/pktgen.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/net/core/pktgen.c b/net/core/pktgen.c > index 508155b..33bdb76 100644 > --- a/net/core/pktgen.c > +++ b/net/core/pktgen.c > @@ -2587,7 +2587,7 @@ static void free_SAs(struct pktgen_dev *pkt_dev) > } > } > > -static int process_ipsec(struct pktgen_dev *pkt_dev, > +static bool process_ipsec(struct pktgen_dev *pkt_dev, > struct sk_buff *skb, __be16 protocol) > { > if (pkt_dev->flags & F_IPSEC_ON) { > @@ -2626,10 +2626,10 @@ static int process_ipsec(struct pktgen_dev *pkt_dev, > ip_send_check(iph); > } > } > - return 1; > + return true; > err: > kfree_skb(skb); > - return 0; > + return false; > } > #endif >