From: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
To: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Cc: Martyn Welch <martyn.welch@ge.com>,
Manohar Vanga <manohar.vanga@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Igor Alekseev <igor.alekseev@itep.ru>,
Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Subject: [PATCHv2 02/16] vme: tsi148: fix DMA lists longer that one item
Date: Thu, 28 May 2015 12:31:08 +0300 [thread overview]
Message-ID: <1432805482-24129-3-git-send-email-dmitry.kalinkin@gmail.com> (raw)
In-Reply-To: <1432805482-24129-1-git-send-email-dmitry.kalinkin@gmail.com>
DMA lists on tsi148 weren't processed further than the first item
because of the broken logic. This regression was introduced in:
ac1a4f2caf7b071 "Staging: VME: Ensure TSI148 link list descriptors..."
Signed-off-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
---
drivers/vme/bridges/vme_tsi148.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148.c
index 895c2a3..1be4136 100644
--- a/drivers/vme/bridges/vme_tsi148.c
+++ b/drivers/vme/bridges/vme_tsi148.c
@@ -1844,8 +1844,8 @@ static int tsi148_dma_list_add(struct vme_dma_list *list,
reg_split((unsigned long long)entry->dma_handle, &address_high,
&address_low);
- entry->descriptor.dnlau = cpu_to_be32(address_high);
- entry->descriptor.dnlal = cpu_to_be32(address_low);
+ prev->descriptor.dnlau = cpu_to_be32(address_high);
+ prev->descriptor.dnlal = cpu_to_be32(address_low);
}
--
1.8.3.1
next prev parent reply other threads:[~2015-05-28 9:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 9:31 [PATCHv2 00/16] vme DMA and user space driver improvements Dmitry Kalinkin
2015-05-28 9:31 ` [PATCHv2 01/16] Documentation: mention vme_master_mmap() in VME API Dmitry Kalinkin
2015-05-28 9:31 ` Dmitry Kalinkin [this message]
2015-05-28 9:31 ` [PATCHv2 03/16] vme: tsi148: fix first DMA item mapping Dmitry Kalinkin
2015-05-28 9:31 ` [PATCHv2 04/16] vme: stop DMA transfer on interruption Dmitry Kalinkin
2015-05-28 9:31 ` [PATCHv2 05/16] staging: vme_user: refactor llseek to switch(){} Dmitry Kalinkin
2015-05-28 9:31 ` [PATCHv2 06/16] vme: check for A64 overflow in vme_check_window() Dmitry Kalinkin
2015-05-28 9:31 ` [PATCHv2 07/16] vme: export vme_check_window() Dmitry Kalinkin
2015-05-28 9:31 ` [PATCHv2 08/16] staging: vme_user: provide DMA functionality Dmitry Kalinkin
2015-05-28 9:31 ` [PATCHv2 09/16] vme: ca91cx42: return error code on DMA error Dmitry Kalinkin
2015-05-28 9:31 ` [PATCHv2 10/16] vme: ca91cx42: fix LM_CTL address mask Dmitry Kalinkin
2015-05-28 9:31 ` [PATCHv2 11/16] staging: vme_user: remove unused counters Dmitry Kalinkin
2015-05-28 9:31 ` [PATCHv2 12/16] staging: vme_user: remove forward declarations Dmitry Kalinkin
2015-05-28 9:31 ` [PATCHv2 13/16] staging: vme_user: remove open/release Dmitry Kalinkin
2015-05-28 9:31 ` [PATCHv2 14/16] staging: vme_user: remove buf_unalloc helper Dmitry Kalinkin
2015-05-28 9:31 ` [PATCHv2 15/16] vme: tsi148: depend on HAS_DMA for Kconfig Dmitry Kalinkin
2015-05-28 9:31 ` [PATCHv2 16/16] vme: provide uapi header Dmitry Kalinkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432805482-24129-3-git-send-email-dmitry.kalinkin@gmail.com \
--to=dmitry.kalinkin@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=igor.alekseev@itep.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=manohar.vanga@gmail.com \
--cc=martyn.welch@ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®