From: Xavier Roche <roche@httrack.com>
To: devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org,
Marek Belisko <marek.belisko@gmail.com>,
Xavier Roche <roche@httrack.com>
Subject: [PATCH] staging: ft1000: warning removal: extern functions to static ones
Date: Thu, 28 May 2015 17:24:56 +0200 [thread overview]
Message-ID: <1432826696-23001-1-git-send-email-roche@httrack.com> (raw)
Local functions not used in other modules should be static, not extern.
(patch checked against linux-next and staging)
Signed-off-by: Xavier Roche <roche@httrack.com>
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c | 24 +++++++++++-----------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c
index 83683e9..3237ee73 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c
@@ -82,12 +82,12 @@
#define STATE_DONE_PROV 0x06
#define STATE_DONE_FILE 0x07
-u16 get_handshake(struct net_device *dev, u16 expected_value);
-void put_handshake(struct net_device *dev, u16 handshake_value);
-u16 get_request_type(struct net_device *dev);
-long get_request_value(struct net_device *dev);
-void put_request_value(struct net_device *dev, long lvalue);
-u16 hdr_checksum(struct pseudo_hdr *pHdr);
+static u16 get_handshake(struct net_device *dev, u16 expected_value);
+static void put_handshake(struct net_device *dev, u16 handshake_value);
+static u16 get_request_type(struct net_device *dev);
+static long get_request_value(struct net_device *dev);
+static void put_request_value(struct net_device *dev, long lvalue);
+static u16 hdr_checksum(struct pseudo_hdr *pHdr);
struct dsp_file_hdr {
u32 version_id; /* Version ID of this image format. */
@@ -146,7 +146,7 @@ void card_bootload(struct net_device *dev)
spin_unlock_irqrestore(&info->dpram_lock, flags);
}
-u16 get_handshake(struct net_device *dev, u16 expected_value)
+static u16 get_handshake(struct net_device *dev, u16 expected_value)
{
struct ft1000_info *info = netdev_priv(dev);
u16 handshake;
@@ -180,7 +180,7 @@ u16 get_handshake(struct net_device *dev, u16 expected_value)
}
-void put_handshake(struct net_device *dev, u16 handshake_value)
+static void put_handshake(struct net_device *dev, u16 handshake_value)
{
struct ft1000_info *info = netdev_priv(dev);
u32 tempx;
@@ -196,7 +196,7 @@ void put_handshake(struct net_device *dev, u16 handshake_value)
}
}
-u16 get_request_type(struct net_device *dev)
+static u16 get_request_type(struct net_device *dev)
{
struct ft1000_info *info = netdev_priv(dev);
u16 request_type;
@@ -215,7 +215,7 @@ u16 get_request_type(struct net_device *dev)
}
-long get_request_value(struct net_device *dev)
+static long get_request_value(struct net_device *dev)
{
struct ft1000_info *info = netdev_priv(dev);
long value;
@@ -244,7 +244,7 @@ long get_request_value(struct net_device *dev)
}
-void put_request_value(struct net_device *dev, long lvalue)
+static void put_request_value(struct net_device *dev, long lvalue)
{
struct ft1000_info *info = netdev_priv(dev);
u16 size;
@@ -271,7 +271,7 @@ void put_request_value(struct net_device *dev, long lvalue)
}
-u16 hdr_checksum(struct pseudo_hdr *pHdr)
+static u16 hdr_checksum(struct pseudo_hdr *pHdr)
{
u16 *usPtr = (u16 *)pHdr;
u16 chksum;
--
1.9.1
next reply other threads:[~2015-05-28 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 15:24 Xavier Roche [this message]
2015-05-28 16:25 ` Greg KH
2015-05-28 21:16 ` Xavier Roche
2015-05-29 20:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432826696-23001-1-git-send-email-roche@httrack.com \
--to=roche@httrack.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome