From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754171AbbE1SaS (ORCPT ); Thu, 28 May 2015 14:30:18 -0400 Received: from smtprelay0023.hostedemail.com ([216.40.44.23]:52976 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753624AbbE1SaN (ORCPT ); Thu, 28 May 2015 14:30:13 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3866:3867:3868:3871:3873:4321:5007:6261:10004:10400:10848:11026:11232:11658:11914:12114:12296:12438:12517:12519:12740:13069:13095:13311:13357:13972:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: ocean47_75ec16e6ce439 X-Filterd-Recvd-Size: 1541 Message-ID: <1432837809.1556.3.camel@perches.com> Subject: Re: [PATCH] pinctrl: fix confusing debug message in pinctrl_register_map() From: Joe Perches To: Masahiro Yamada Cc: linux-gpio@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org Date: Thu, 28 May 2015 11:30:09 -0700 In-Reply-To: <1432817579-4720-1-git-send-email-yamada.masahiro@socionext.com> References: <1432817579-4720-1-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-05-28 at 21:52 +0900, Masahiro Yamada wrote: > There are two types for pinctrl maps: pinmux and pinconfig > This debug message shows the number of maps of both types. > The string "pinmux map" is not precise. Let's say "pinctrl map" > instead. [] > diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c [] > @@ -1115,7 +1115,7 @@ int pinctrl_register_map(struct pinctrl_map const *maps, unsigned num_maps, > int i, ret; > struct pinctrl_maps *maps_node; > > - pr_debug("add %d pinmux maps\n", num_maps); > + pr_debug("add %d pinctrl maps\n", num_maps); You might want to fix the %d/%u mismatch too