From: Andi Kleen <andi@firstfloor.org>
To: sukadev@linux.vnet.ibm.com
Cc: jolsa@redhat.com, mingo@kernel.org, acme@kernel.org,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 3/3] perf, tools: Fix jevents dependencies
Date: Thu, 28 May 2015 13:20:02 -0700 [thread overview]
Message-ID: <1432844402-11649-4-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1432844402-11649-1-git-send-email-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
The "find" based dependencies for the JSON files didn't work me. I
didn't get a rebuild when the JSON files changed. Change it to
use wildcard. Also add a dependency for the jevents binary itself
and for the mapfile.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/pmu-events/Build | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build
index 7e0c85c..e900ecc 100644
--- a/tools/perf/pmu-events/Build
+++ b/tools/perf/pmu-events/Build
@@ -1,10 +1,12 @@
jevents-y += json.o jsmn.o jevents.o
pmu-events-y += pmu-events.o
-JSON = $(shell find pmu-events/arch/$(ARCH) -name '*.json')
#
# Locate/process JSON files in pmu-events/arch/
# directory and create tables in pmu-events.c.
#
-$(OUTPUT)pmu-events/pmu-events.c: $(JSON)
+$(OUTPUT)pmu-events/pmu-events.c: $(wildcard pmu-events/arch/$(ARCH)/*.json) \
+ $(wildcard pmu-events/arch/$(ARCH)/*/*.json) \
+ pmu-events/arch/$(ARCH)/mapfile.csv \
+ $(JEVENTS)
$(Q)$(call echo-cmd,gen)$(JEVENTS) $(ARCH) pmu-events/arch $(OUTPUT)pmu-events/pmu-events.c
--
2.1.0
next prev parent reply other threads:[~2015-05-28 20:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 20:19 perf: Additional improvements for json event lists Andi Kleen
2015-05-28 20:20 ` [PATCH 1/3] perf, tools: Add override support for event list CPUID Andi Kleen
2015-05-28 20:20 ` [PATCH 2/3] perf, tools: Support long descriptions with perf list -v Andi Kleen
2015-05-28 20:20 ` Andi Kleen [this message]
2015-05-28 20:57 ` [PATCH 3/3] perf, tools: Fix jevents dependencies Sukadev Bhattiprolu
2015-05-28 21:15 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432844402-11649-4-git-send-email-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome