From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932717AbbE2Awf (ORCPT ); Thu, 28 May 2015 20:52:35 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:33406 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932214AbbE2As6 (ORCPT ); Thu, 28 May 2015 20:48:58 -0400 From: "Luis R. Rodriguez" To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, "Luis R. Rodriguez" , Ming Lei , Seth Forshee , Kyle McMartin Subject: [PATCH] firmware: add missing kfree for work on async call Date: Thu, 28 May 2015 17:46:42 -0700 Message-Id: <1432860402-18213-1-git-send-email-mcgrof@do-not-panic.com> X-Mailer: git-send-email 2.1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Luis R. Rodriguez" The recent fix to use kstrdup_const() failed to add a kfree upon failure of name allocation... Cc: Ming Lei Cc: Seth Forshee Cc: Kyle McMartin Cc: Greg Kroah-Hartman Signed-off-by: Luis R. Rodriguez --- Sorry about that.. drivers/base/firmware_class.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index 8c3aa3c..9c42883 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -1307,8 +1307,10 @@ request_firmware_nowait( fw_work->module = module; fw_work->name = kstrdup_const(name, gfp); - if (!fw_work->name) + if (!fw_work->name) { + kfree(fw_work); return -ENOMEM; + } fw_work->device = device; fw_work->context = context; fw_work->cont = cont; -- 2.3.2.209.gd67f9d5.dirty