From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
<x86@kernel.org>
Subject: [PATCH 02/15] x86: don't use module_init in non-modular devicetree.c code
Date: Thu, 28 May 2015 20:48:00 -0400 [thread overview]
Message-ID: <1432860493-23831-3-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1432860493-23831-1-git-send-email-paul.gortmaker@windriver.com>
The devicetree.o is built for "OF" -- which is bool, and hence
this code is either present or absent. It will never be modular,
so using module_init as an alias for __initcall can be somewhat
misleading.
Fix this up now, so that we can relocate module_init from
init.h into module.h in the future. If we don't do this, we'd
have to add module.h to obviously non-modular code, and that
would be a worse thing.
Note that direct use of __initcall is discouraged, vs. one
of the priority categorized subgroups. As __initcall gets
mapped onto device_initcall, our use of device_initcall
directly in this change means that the runtime impact is
zero -- it will remain at level 6 in initcall ordering.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
arch/x86/kernel/devicetree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c
index 6367a780cc8c..3743b92089de 100644
--- a/arch/x86/kernel/devicetree.c
+++ b/arch/x86/kernel/devicetree.c
@@ -65,7 +65,7 @@ static int __init add_bus_probe(void)
return of_platform_bus_probe(NULL, ce4100_ids, NULL);
}
-module_init(add_bus_probe);
+device_initcall(add_bus_probe);
#ifdef CONFIG_PCI
struct device_node *pcibios_get_phb_of_node(struct pci_bus *bus)
--
2.2.1
next prev parent reply other threads:[~2015-05-29 0:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 0:47 [PATCH 00/15] Replace module_init with device_initcall in non modules Paul Gortmaker
2015-05-29 0:47 ` [PATCH 01/15] x86: don't use module_init in non-modular intel_mid_vrtc.c Paul Gortmaker
2015-05-29 0:48 ` Paul Gortmaker [this message]
2015-05-29 0:48 ` [PATCH 03/15] powerpc: use device_initcall for registering rtc devices Paul Gortmaker
2015-05-29 0:48 ` [PATCH 04/15] powerpc: don't use module_init in non-modular 83xx suspend code Paul Gortmaker
2015-05-29 0:48 ` [PATCH 05/15] arm: don't use module_init in non-modular mach-vexpress/spc.c code Paul Gortmaker
2015-05-29 0:48 ` [PATCH 06/15] alpha: don't use module_init for non-modular core code Paul Gortmaker
2015-05-29 5:51 ` Matt Turner
2015-05-29 15:15 ` Paul Gortmaker
2015-05-29 0:48 ` [PATCH 07/15] ia64: don't use module_init for non-modular core kernel/mca.c code Paul Gortmaker
2015-05-29 0:48 ` [PATCH 08/15] ia64: don't use module_init in non-modular sim/simscsi.c code Paul Gortmaker
2015-05-29 0:48 ` [PATCH 09/15] cris: don't use module_init for non-modular core intmem.c code Paul Gortmaker
2015-05-29 0:48 ` [PATCH 10/15] parisc: don't use module_init for non-modular core pdc_cons code Paul Gortmaker
2015-05-29 0:48 ` [PATCH 11/15] parisc64: don't use module_init for non-modular core perf code Paul Gortmaker
2015-05-29 0:48 ` [PATCH 12/15] mn10300: don't use module_init in non-modular flash.c code Paul Gortmaker
2015-05-29 0:48 ` [PATCH 13/15] sh: don't use module_init in non-modular psw.c code Paul Gortmaker
2015-05-29 0:48 ` [PATCH 14/15] xtensa: don't use module_init for non-modular core network.c code Paul Gortmaker
2015-05-29 0:48 ` [PATCH 15/15] drivers/clk: don't use module_init in clk-nomadik.c which is non-modular Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432860493-23831-3-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome