From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755895AbbE2JvZ (ORCPT ); Fri, 29 May 2015 05:51:25 -0400 Received: from smtprelay0112.hostedemail.com ([216.40.44.112]:58709 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754104AbbE2JvR (ORCPT ); Fri, 29 May 2015 05:51:17 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2110:2196:2199:2393:2553:2559:2562:2692:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3872:3873:3874:4321:4385:5007:6119:6261:7875:10004:10400:10848:11026:11232:11658:11914:12043:12296:12438:12517:12519:12555:12740:13069:13071:13149:13161:13229:13230:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: death25_ae0c114be635 X-Filterd-Recvd-Size: 1974 Message-ID: <1432893073.29807.15.camel@perches.com> Subject: Re: [PATCH] fixup! dmaengine: pxa_dma: add debug information From: Joe Perches To: robert.jarzmik@free.fr Cc: Vinod Koul , Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 29 May 2015 02:51:13 -0700 In-Reply-To: <1617548760.717381111.1432891749082.JavaMail.root@zimbra1-e1.priv.proxad.net> References: <1617548760.717381111.1432891749082.JavaMail.root@zimbra1-e1.priv.proxad.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-05-29 at 11:29 +0200, robert.jarzmik@free.fr wrote: > ----- Mail original ----- > De: "Vinod Koul" > On Wed, May 27, 2015 at 11:23:40PM +0200, Robert Jarzmik wrote: > > This fixes the following error: [] > And with a a bit closer look check this commit, especially the date : > commit 0bac33653b06a5f80a5c04e275eb33db9493b85a > Author: Joe Perches > Date: Sat May 23 12:00:38 2015 +1000 > > fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void Hello Robert. The return value of that dbg_show_requester_chan function was incorrect and the increment of pos was an example of why the seq_printf return value was changed to void. It was a pretty common error and easy to understand given the expectation that seq_printf should work like printf. It's a pity it bit you. but this type of patch collision should be a bit more difficult to reoccur in the future. cheers, Joe