From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753480AbbFAOPK (ORCPT ); Mon, 1 Jun 2015 10:15:10 -0400 Received: from casper.infradead.org ([85.118.1.10]:50823 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753437AbbFAOPB convert rfc822-to-8bit (ORCPT ); Mon, 1 Jun 2015 10:15:01 -0400 Message-ID: <1433168096.11346.19.camel@twins> Subject: Re: [PATCH 10/11] x86: perf_event_intel_bts.c: use arch_initcall to hook in enabling From: Peter Zijlstra To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , Thomas Gleixner , "H. Peter Anvin" , x86@kernel.org Date: Mon, 01 Jun 2015 16:14:56 +0200 In-Reply-To: <556C67F6.9060503@windriver.com> References: <1433120052-18281-1-git-send-email-paul.gortmaker@windriver.com> <1433120052-18281-11-git-send-email-paul.gortmaker@windriver.com> <20150601070408.GM19282@twins.programming.kicks-ass.net> <556C67F6.9060503@windriver.com> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-06-01 at 10:11 -0400, Paul Gortmaker wrote: > On 15-06-01 03:04 AM, Peter Zijlstra wrote: > > On Sun, May 31, 2015 at 08:54:11PM -0400, Paul Gortmaker wrote: > >> This was using module_init, but there is no way this code can > >> be modular. > > > > No, I think you could actually make it modular if you really wanted to. > > By "really wanted to" -- do you mean future changes that someone might do? Yeah, I think we read "no way this code can be modular" differently. I'm reading it like; it can easily be, all it requires is this little patch, where you're reading it like Kconfig changes.