From: Joe Perches <joe@perches.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Kashyap Desai <kashyap.desai@avagotech.com>,
Uday Lingala <uday.lingala@avagotech.com>,
Sumit Saxena <sumit.saxena@avagotech.com>,
megaraidlinux.pdl@avagotech.com,
"James E.J. Bottomley" <JBottomley@odin.com>,
Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] megaraid : use dev_printk when possible
Date: Mon, 01 Jun 2015 09:10:24 -0700 [thread overview]
Message-ID: <1433175024.4861.11.camel@perches.com> (raw)
In-Reply-To: <20150601154003.23309.70647.stgit@bhelgaas-glaptop2.roam.corp.google.com>
On Mon, 2015-06-01 at 10:40 -0500, Bjorn Helgaas wrote:
> Use dev_printk() when possible to make messages more useful.
[]
> diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
[]
> @@ -268,7 +268,7 @@ mega_query_adapter(adapter_t *adapter)
> raw_mbox[2] = NC_SUBOP_PRODUCT_INFO; /* i.e. 0x0E */
>
> if ((retval = issue_scb_block(adapter, raw_mbox)))
> - printk(KERN_WARNING
> + dev_warn(&adapter->dev->dev,
> "megaraid: Product_info cmd failed with error: %d\n",
> retval);
Wouldn't these be a bit redundant with a "megaraid: " prefix now?
Perhaps it'd be nicer to realign arguments too.
next prev parent reply other threads:[~2015-06-01 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 15:39 [PATCH v2 0/3] megaraid: use dev_printk() " Bjorn Helgaas
2015-06-01 15:40 ` [PATCH v2 1/3] megaraid : use dev_printk " Bjorn Helgaas
2015-06-01 16:10 ` Joe Perches [this message]
2015-06-01 16:40 ` Bjorn Helgaas
2015-06-01 16:44 ` Joe Perches
2015-06-01 16:53 ` Bjorn Helgaas
2015-06-01 15:40 ` [PATCH v2 2/3] megaraid_sas " Bjorn Helgaas
2015-06-01 15:40 ` [PATCH v2 3/3] megaraid_sas : fix whitespace errors Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433175024.4861.11.camel@perches.com \
--to=joe@perches.com \
--cc=JBottomley@odin.com \
--cc=bhelgaas@google.com \
--cc=hch@lst.de \
--cc=kashyap.desai@avagotech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=megaraidlinux.pdl@avagotech.com \
--cc=sumit.saxena@avagotech.com \
--cc=uday.lingala@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®