From: Toshi Kani <toshi.kani@hp.com>
To: rjw@rjwysocki.net, dan.j.williams@intel.com
Cc: linux-acpi@vger.kernel.org, linux-nvdimm@ml01.01.org,
linux-kernel@vger.kernel.org, Toshi Kani <toshi.kani@hp.com>
Subject: [PATCH 1/3] acpi: Fix acpi_map_pxm_to_node() to handle numa_off
Date: Tue, 2 Jun 2015 18:26:50 -0600 [thread overview]
Message-ID: <1433291212-23367-2-git-send-email-toshi.kani@hp.com> (raw)
In-Reply-To: <1433291212-23367-1-git-send-email-toshi.kani@hp.com>
When numa_off is set, NUMA is turned off and node 0 is the only
valid node on the system. The kernel skips parsing ACPI SRAT
table in this case.
Change acpi_map_pxm_to_node() to always return 0 when numa_off
is set. Also move the range check of a proximity ID from
acpi_get_node() to acpi_map_pxm_to_node() after the numa_off
check. This keeps the interfaces to return 0 regardless of
proximity ID values.
Signed-off-by: Toshi Kani <toshi.kani@hp.com>
---
drivers/acpi/numa.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c
index 1333cbdc..4898082 100644
--- a/drivers/acpi/numa.c
+++ b/drivers/acpi/numa.c
@@ -70,7 +70,15 @@ static void __acpi_map_pxm_to_node(int pxm, int node)
int acpi_map_pxm_to_node(int pxm)
{
- int node = pxm_to_node_map[pxm];
+ int node;
+
+ if (numa_off)
+ return 0;
+
+ if (pxm < 0 || pxm >= MAX_PXM_DOMAINS)
+ return NUMA_NO_NODE;
+
+ node = pxm_to_node_map[pxm];
if (node == NUMA_NO_NODE) {
if (nodes_weight(nodes_found_map) >= MAX_NUMNODES)
@@ -328,8 +336,6 @@ int acpi_get_node(acpi_handle handle)
int pxm;
pxm = acpi_get_pxm(handle);
- if (pxm < 0 || pxm >= MAX_PXM_DOMAINS)
- return NUMA_NO_NODE;
return acpi_map_pxm_to_node(pxm);
}
next prev parent reply other threads:[~2015-06-03 0:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 0:26 [PATCH 0/3] Add NUMA support for NVDIMM devices Toshi Kani
2015-06-03 0:26 ` Toshi Kani [this message]
2015-06-06 0:33 ` [PATCH 1/3] acpi: Fix acpi_map_pxm_to_node() to handle numa_off Toshi Kani
2015-06-03 0:26 ` [PATCH 2/3] acpi: Add export to acpi_map_pxm_to_node() Toshi Kani
2015-06-03 0:26 ` [PATCH 3/3] libnvdimm: Add sysfs numa_node to NVDIMM devices Toshi Kani
2015-06-03 1:01 ` Dan Williams
2015-06-03 2:51 ` Dan Williams
2015-06-03 15:23 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433291212-23367-2-git-send-email-toshi.kani@hp.com \
--to=toshi.kani@hp.com \
--cc=dan.j.williams@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®