From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754736AbbFCUxq (ORCPT ); Wed, 3 Jun 2015 16:53:46 -0400 Received: from mail1.windriver.com ([147.11.146.13]:59185 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752807AbbFCUxi (ORCPT ); Wed, 3 Jun 2015 16:53:38 -0400 From: Paul Gortmaker To: CC: , Paul Gortmaker , Pratik Patel , "Ivan T. Ivanov" , Mathieu Poirier , Greg Kroah-Hartman Subject: [PATCH staging] drivers/hwtracing: fix coresight-replicator-qcom implicit usage Date: Wed, 3 Jun 2015 16:52:57 -0400 Message-ID: <1433364777-29651-1-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.2.1 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In commit 620cf787c121f39b5223e43bad3d1b7c66ecead5 ("coresight: replicator: Add Qualcomm CoreSight Replicator driver") this driver was added. It uses module_amba_driver(replicator_driver) to register itself with the system -- which is just an alias for module_driver. This currently works by relying on getting that via init.h but we are planning to move that code[1] to module.h -- at which time this will fail to compile since it does not include module.h currently, resulting in: drivers/hwtracing/coresight/coresight-replicator-qcom.c:214:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int] drivers/hwtracing/coresight/coresight-replicator-qcom.c:214:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int] In the future, the amba support may want to create another alias that uses builtin_driver[2] for cases like this which are using bool Kconfig triggers, but for now we just fix the implicit include. [1] https://lkml.kernel.org/r/1433276168-21550-1-git-send-email-paul.gortmaker@windriver.com [2] https://lkml.kernel.org/r/1431287385-1526-1-git-send-email-paul.gortmaker@windriver.com Cc: Pratik Patel Cc: Ivan T. Ivanov Cc: Mathieu Poirier Cc: Greg Kroah-Hartman Signed-off-by: Paul Gortmaker --- [Note: Commit 620cf787c121 is only in linux-next trees via staging-next; this fixes a next build fail when staging-next is merged with [1] above.] drivers/hwtracing/coresight/coresight-replicator-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hwtracing/coresight/coresight-replicator-qcom.c b/drivers/hwtracing/coresight/coresight-replicator-qcom.c index deacea49af36..584059e9e866 100644 --- a/drivers/hwtracing/coresight/coresight-replicator-qcom.c +++ b/drivers/hwtracing/coresight/coresight-replicator-qcom.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include -- 2.2.1