From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753550AbbFDAGW (ORCPT ); Wed, 3 Jun 2015 20:06:22 -0400 Received: from mail1.windriver.com ([147.11.146.13]:63222 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752107AbbFDAGP (ORCPT ); Wed, 3 Jun 2015 20:06:15 -0400 From: Paul Gortmaker To: CC: Paul Gortmaker , Pratik Patel , Kaixu Xia , Mathieu Poirier , Greg Kroah-Hartman Subject: [PATCH staging] drivers/hwtracing: fix coresight-etm4x implicit usage Date: Wed, 3 Jun 2015 20:03:56 -0400 Message-ID: <1433376236-7347-1-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In commit 2e1cdfe184b5202d51e0611d7a051e2bea303946 ("coresight-etm4x: Adding CoreSight ETM4x driver") this driver was added. It uses module_amba_driver() to register itself with the system, which is just an alias for module_driver. This currently works by relying on getting that via init.h but we are planning to move that code[1] to module.h -- at which time this will fail to compile since it does not include module.h currently, resulting in: drivers/hwtracing/coresight/coresight-etm4x.c:2701:1: note: in expansion of macro ‘module_amba_driver’ module_amba_driver(etm4x_driver); ^ include/linux/device.h:1296:1: error: type defaults to ‘int’ in declaration of ‘module_init’ [-Werror=implicit-int] module_init(__driver##_init); \ ^ In the future, the amba support may want to create another alias that uses builtin_driver[2] for cases like this which are using bool Kconfig triggers, but for now we just fix the implicit include. [1] https://lkml.kernel.org/r/1433276168-21550-1-git-send-email-paul.gortmaker@windriver.com [2] https://lkml.kernel.org/r/1431287385-1526-1-git-send-email-paul.gortmaker@windriver.com Cc: Pratik Patel Cc: Kaixu Xia Cc: Mathieu Poirier Cc: Greg Kroah-Hartman Signed-off-by: Paul Gortmaker --- [Note: Commit 2e1cdfe184b520 is only in linux-next trees via staging-next; this fixes a next build fail when staging-next is merged with [1] above.] drivers/hwtracing/coresight/coresight-etm4x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c index f0b50af4fc30..1312e993c501 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x.c +++ b/drivers/hwtracing/coresight/coresight-etm4x.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include -- 2.2.1