From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753036AbbFDLmM (ORCPT ); Thu, 4 Jun 2015 07:42:12 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:35679 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752200AbbFDLmL (ORCPT ); Thu, 4 Jun 2015 07:42:11 -0400 From: Sudip Mukherjee To: Thomas Petazzoni , =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= , Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] staging: fbtft: fix out of bound access Date: Thu, 4 Jun 2015 17:12:01 +0530 Message-Id: <1433418121-9434-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org size of str is 16, but in snprintf the size was mentioned as 128. Signed-off-by: Sudip Mukherjee --- drivers/staging/fbtft/fbtft-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index ce64521..0af84b5 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b/drivers/staging/fbtft/fbtft-core.c @@ -1096,7 +1096,7 @@ static int fbtft_init_display_dt(struct fbtft_par *par) /* make debug message */ msg[0] = '\0'; for (j = 0; j < i; j++) { - snprintf(str, 128, " %02X", buf[j]); + snprintf(str, 16, " %02X", buf[j]); strcat(msg, str); } fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, -- 1.8.1.2