From: Masami Ichikawa <masami256@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Masami Ichikawa <masami256@gmail.com>
Subject: [PATCH] kasan: Set shadow memory is not memory leaked
Date: Sat, 6 Jun 2015 23:10:31 +0900 [thread overview]
Message-ID: <1433599831-6196-1-git-send-email-masami256@gmail.com> (raw)
kmemleak reported memory leak in kasan_module_alloc() like following
log, even through kasan_free_shadow() frees that address.
unreferenced object 0xfffffbfff40ac000 (size 118784):
comm "modprobe", pid 196, jiffies 4294878847 (age 87.590s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff81853a8e>] kmemleak_alloc+0x4e/0xc0
[<ffffffff812868d0>] __vmalloc_node_range+0x340/0x3f0
[<ffffffff812b0ae2>] kasan_module_alloc+0x72/0xd0
[<ffffffff8108c908>] module_alloc+0x78/0xb0
[<ffffffff81189474>] module_alloc_update_bounds+0x14/0x70
[<ffffffff8118a457>] load_module+0xf67/0x4670
[<ffffffff8118dd35>] SyS_init_module+0x1d5/0x220
[<ffffffff8186642e>] system_call_fastpath+0x12/0x71
[<ffffffffffffffff>] 0xffffffffffffffff
Kmemleak may think anyone take care of result of __vmalloc_node_range()
after the function.
So, it would be nice to call kmemleak_not_leak() to tell memory is not
leaked.
Signed-off-by: Masami Ichikawa <masami256@gmail.com>
---
mm/kasan/kasan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/kasan/kasan.c b/mm/kasan/kasan.c
index 6c513a6..0ef75b9 100644
--- a/mm/kasan/kasan.c
+++ b/mm/kasan/kasan.c
@@ -430,6 +430,7 @@ int kasan_module_alloc(void *addr, size_t size)
__builtin_return_address(0));
if (ret) {
+ kmemleak_not_leak(ret);
find_vm_area(addr)->flags |= VM_KASAN;
return 0;
}
--
2.4.2
reply other threads:[~2015-06-06 14:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433599831-6196-1-git-send-email-masami256@gmail.com \
--to=masami256@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®